netdev - Re: [PATCH net] netfilter: remove the nh_scope test in rpfilter_lookup_reverse of ipt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151004214802.GB6032@breakpoint.cc>
Date:	Sun, 4 Oct 2015 23:48:02 +0200
From:	Florian Westphal <fw@...len.de>
To:	Xin Long <lucien.xin@...il.com>
Cc:	network dev <netdev@...r.kernel.org>, fw@...len.de
Subject: Re: [PATCH net] netfilter: remove the nh_scope test in
 rpfilter_lookup_reverse of ipt_rpfilter

Xin Long <lucien.xin@...il.com> wrote:
> it seems the test is bogus and can be removed to fix this issue.
> 
> 	if (dev_match || flags & XT_RPFILTER_LOOSE)
> 		return FIB_RES_NH(res).nh_scope <= RT_SCOPE_HOST;
> 
> ipv6 does not have this issue.

netfilter patches should be sent to netfilter-devel@...r.kernel.org

>  #endif
> -	if (dev_match || flags & XT_RPFILTER_LOOSE)
> -		return FIB_RES_NH(res).nh_scope <= RT_SCOPE_HOST;
>  	return dev_match;
>  }

This breaks --loose option, no?

Thats why I earlier suggested to change this to

> -	if (dev_match || flags & XT_RPFILTER_LOOSE)
> -		return FIB_RES_NH(res).nh_scope <= RT_SCOPE_HOST;
+	return dev_match || flags & XT_RPFILTER_LOOSE;

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html