netdev - Re: [PATCH net-next v2 4/4] openvswitch: IPv6 support for ovs_tunnel_get_egress

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALnjE+q_nPothrfHdwLZXTVu2MwJipFsUy-jQhpPPEbOKT3DeQ@mail.gmail.com>
Date:	Mon, 5 Oct 2015 11:05:00 -0700
From:	Pravin Shelar <pshelar@...ira.com>
To:	Jesse Gross <jesse@...ira.com>
Cc:	Jiri Benc <jbenc@...hat.com>, netdev <netdev@...r.kernel.org>,
	"dev@...nvswitch.org" <dev@...nvswitch.org>
Subject: Re: [PATCH net-next v2 4/4] openvswitch: IPv6 support for ovs_tunnel_get_egress_info

On Fri, Oct 2, 2015 at 5:57 PM, Jesse Gross <jesse@...ira.com> wrote:
> On Fri, Oct 2, 2015 at 12:32 PM, Pravin Shelar <pshelar@...ira.com> wrote:
>> On Thu, Oct 1, 2015 at 11:00 PM, Jiri Benc <jbenc@...hat.com> wrote:
>>> On Thu, 1 Oct 2015 17:11:56 -0700, Pravin Shelar wrote:
>>>> I dont see point of adding this code when IPv6 sampling not support by
>>>> the patch series.
>>>
>>> It was requested by Jesse:
>>> http://article.gmane.org/gmane.linux.network/380348
>>>
>>
>> I don't think we can use this function, lwtunnel device need new ndo_
>> operation to export this information. So lets defer this patch till we
>> have solution for retrieving egress info from lwtunnel devices.
>
> I don't entirely disagree with this but I'm also nervous about
> completely leaving it out. It seems like when this issue does get
> fixed, it is likely that the person who does it will just convert
> whatever code is there and not necessarily think about IPv6 since it's
> not an IPv6 feature. If that happens, we'll have a hidden problem in
> IPv6, which is somewhat unfortunately as try to advance IPv6 forward.

The code is pretty different for different tunnel. It is possible to
take the code and reuse it. But that would involve lot of refactoring
into existing code for every flow tunnel based tunnel implementation.
I do not want to do it as part of fix to net branch.
I have sent out patch to fix the egress tunnel info issue with
lwtunnel. Once that is merged we can have complete IPv6 tunnel support
on net-next.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html