netdev - Re: [PATCH net-next v2 2/2] net: Microchip encx24j600 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151005.040042.705688813405698539.davem@davemloft.net>
Date:	Mon, 05 Oct 2015 04:00:42 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jon@...gle.org
Cc:	broonie@...nel.org, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	jringle@...dpoint.com
Subject: Re: [PATCH net-next v2 2/2] net: Microchip encx24j600 driver

From: David Miller <davem@...emloft.net>
Date: Mon, 05 Oct 2015 03:54:55 -0700 (PDT)

> From: jon@...gle.org
> Date: Thu,  1 Oct 2015 07:43:21 -0400
> 
>> From: Jon Ringle <jringle@...dpoint.com>
>> 
>> This ethernet driver supports the Micorchip enc424j600/626j600 Ethernet
>> controller over a SPI bus interface. This driver makes use of the regmap API to
>> optimize access to registers by caching registers where possible.
>> 
>> Datasheet:
>> http://ww1.microchip.com/downloads/en/DeviceDoc/39935b.pdf
>> 
>> Signed-off-by: Jon Ringle <jringle@...dpoint.com>
> 
> Applied.

Actually, I had to revert both patches.  Please look at the compiler
warnings your code generates:

drivers/mfd/wm5110-tables.c: In function ‘wm5110_patch’:
drivers/mfd/wm5110-tables.c:281:11: warning: passing argument 2 of ‘regmap_register_patch’ from incompatible pointer type [enabled by default]
In file included from include/linux/mfd/arizona/core.h:17:0,
                 from drivers/mfd/wm5110-tables.c:15:
include/linux/regmap.h:727:5: note: expected ‘const struct reg_sequence *’ but argument is of type ‘const struct reg_default *’
drivers/mfd/wm8998-tables.c: In function ‘wm8998_patch’:
drivers/mfd/wm8998-tables.c:50:10: warning: passing argument 2 of ‘regmap_register_patch’ from incompatible pointer type [enabled by default]
In file included from include/linux/mfd/arizona/core.h:17:0,
                 from drivers/mfd/wm8998-tables.c:15:
include/linux/regmap.h:727:5: note: expected ‘const struct reg_sequence *’ but argument is of type ‘const struct reg_default *’