netdev - Re: [PATCH] net: usb: asix: Fix crash on skb alloc failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <69f8994562da8cb064f138b162a99c4d@i4031.net>
Date:	Mon, 05 Oct 2015 09:40:04 -0400
From:	"David B. Robins" <linux@...idrobins.net>
To:	David Miller <davem@...emloft.net>
Cc:	linux-usb@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: usb: asix: Fix crash on skb alloc failure

On 2015-10-05 06:31, David Miller wrote:
> From: "David B. Robins" <linux@...idrobins.net>
> Date: Wed, 30 Sep 2015 16:20:04 -0400
> 
>> If asix_rx_fixup_internal() fails to allocate rx->ax_skb, it will 
>> return
>> but not clear rx->size. rx points to driver private data. A later call
>> assumes that nonzero size means ax_skb was allocated and passes a null
>> ax_skb to skb_put. Changed allocation failure return to clear size 
>> first.
>> 
>> Found testing board with AX88772B devices.
>> 
>> Signed-off-by: David B. Robins <linux@...idrobins.net>
> 
> Applied, thanks.

While I am happy for the patch I submitted to be applied, and it is 
consistent with existing error handling and does fix the specific issue, 
I believe a later series of 5 patches by Dean Jenkins that more 
comprehensively address the issue (grouped under subject "Improve ASIX 
RX memory allocation error handling") should be preferred.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html