netdev - Re: [PATCH net-next] bridge: allow adding of fdb entries pointing to the bridge device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 6 Oct 2015 23:29:29 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Roopa Prabhu <roopa@...ulusnetworks.com>
Cc:	kbuild-all@...org, davem@...emloft.net, netdev@...r.kernel.org,
	nikolay@...ulusnetworks.com, stephen@...workplumber.org,
	bridge@...ts.linux-foundation.org
Subject: Re: [PATCH net-next] bridge: allow adding of fdb entries pointing to
 the bridge device

Hi Roopa,

[auto build test WARNING on next-20151006 -- if it's inappropriate base, please ignore]

config: sh-titan_defconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=sh 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   net/bridge/br_fdb.c: In function 'br_fdb_add':
>> net/bridge/br_fdb.c:784:13: warning: 'p' may be used uninitialized in this function [-Wuninitialized]
   net/bridge/br_fdb.c:850:26: note: 'p' was declared here
   net/bridge/br_fdb.c: In function 'br_fdb_delete':
   net/bridge/br_fdb.c:952:11: warning: 'p' may be used uninitialized in this function [-Wuninitialized]
   net/bridge/br_fdb.c:977:26: note: 'p' was declared here

vim +/p +784 net/bridge/br_fdb.c

eb8d7baa Wilson Kok        2015-05-25  768  
2ba071ec Vlad Yasevich     2013-02-13  769  	fdb = fdb_find(head, addr, vid);
64af1bac stephen hemminger 2011-09-30  770  	if (fdb == NULL) {
64af1bac stephen hemminger 2011-09-30  771  		if (!(flags & NLM_F_CREATE))
64af1bac stephen hemminger 2011-09-30  772  			return -ENOENT;
36fd2b63 stephen hemminger 2011-04-04  773  
2ba071ec Vlad Yasevich     2013-02-13  774  		fdb = fdb_create(head, source, addr, vid);
36fd2b63 stephen hemminger 2011-04-04  775  		if (!fdb)
36fd2b63 stephen hemminger 2011-04-04  776  			return -ENOMEM;
b0a397fb roopa             2013-04-22  777  
b0a397fb roopa             2013-04-22  778  		modified = true;
64af1bac stephen hemminger 2011-09-30  779  	} else {
64af1bac stephen hemminger 2011-09-30  780  		if (flags & NLM_F_EXCL)
64af1bac stephen hemminger 2011-09-30  781  			return -EEXIST;
b0a397fb roopa             2013-04-22  782  
b0a397fb roopa             2013-04-22  783  		if (fdb->dst != source) {
b0a397fb roopa             2013-04-22 @784  			fdb->dst = source;
b0a397fb roopa             2013-04-22  785  			modified = true;
b0a397fb roopa             2013-04-22  786  		}
64af1bac stephen hemminger 2011-09-30  787  	}
36fd2b63 stephen hemminger 2011-04-04  788  
0e29720e Roopa Prabhu      2015-10-06  789  	if (fdb_to_nud(br, fdb) != state) {
145beee8 Vlad Yasevich     2014-05-16  790  		if (state & NUD_PERMANENT) {
145beee8 Vlad Yasevich     2014-05-16  791  			fdb->is_local = 1;
145beee8 Vlad Yasevich     2014-05-16  792  			if (!fdb->is_static) {

:::::: The code at line 784 was first introduced by commit
:::::: b0a397fb352e65e3b6501dca9662617a18862ef1 bridge: Add fdb dst check during fdb update

:::::: TO: roopa <roopa@...ulusnetworks.com>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (15308 bytes)