netdev - Re: [PATCH] ipvs: Remove possibly unused net variable from ip_vs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHA+R7MezkwDg0mTMrR2HZ3sc7OMG2J-ED9F3g4XL7_16QBYyw@mail.gmail.com>
Date:	Tue, 6 Oct 2015 16:27:35 -0700
From:	Cong Wang <cwang@...pensource.com>
To:	Julian Anastasov <ja@....bg>
Cc:	Simon Horman <horms@...ge.net.au>, lvs-devel@...r.kernel.org,
	netdev <netdev@...r.kernel.org>, netfilter-devel@...r.kernel.org,
	Wensong Zhang <wensong@...ux-vs.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>
Subject: Re: [PATCH] ipvs: Remove possibly unused net variable from ip_vs_out

On Tue, Oct 6, 2015 at 11:24 AM, Julian Anastasov <ja@....bg> wrote:
>
>         Hello,
>
> On Tue, 6 Oct 2015, Simon Horman wrote:
>
>> Since 6f2bcea9917d ("ipvs: Pass ipvs into ip_vs_in_icmp and
>> ip_vs_in_icmp_v6") the net variable in ip_vs_out() appears to be unused
>> unless CONFIG_IP_VS_IPV6 is set. To resolve this remove the net variable
>> and dereference net asneeded.
>>
>> Signed-off-by: Simon Horman <horms@...ge.net.au>
>
>         Both patches look good to me
>
> Acked-by: Julian Anastasov <ja@....bg>
>

David sent a same patch earlier:

http://www.spinics.net/lists/netdev/msg345887.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html