netdev - Re: [PATCH 1/2] regmap: only call custom reg_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151005.232956.105884641412802470.davem@davemloft.net>
Date:	Mon, 05 Oct 2015 23:29:56 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	broonie@...nel.org
Cc:	jon@...gle.org, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	jringle@...dpoint.com
Subject: Re: [PATCH 1/2] regmap: only call custom reg_update_bits() if reg
 is marked volatile

From: Mark Brown <broonie@...nel.org>
Date: Mon, 5 Oct 2015 15:57:22 +0100

> On Mon, Oct 05, 2015 at 09:29:31AM -0400, jon@...gle.org wrote:
>> From: Jon Ringle <jringle@...dpoint.com>
>> 
>> The only time that it makes sense to call a custom provided reg_update_bits
>> function, is the register being updated is one that has volatile bits.
>> Otherwise, the normal read/modify/write cycle (where the read is likely to
>> be free from the cache) will do just fine. This should keep the reg cache
>> intact, since volatile registers won't get cached anyway.
> 
> Dave, to be clear please do *not* apply this patch at least for the time
> being - I've not reviewed it or the one from Thursday that you applied
> this morning.

It's applied, it's pushed out to my tree, and therefore this will need to
be fixed up with a relative patch of some sort.

What you don't seem to understand is that my GIT tree is never rebased
or mangled because many people depend upon it.  So once a patch is
applied, that commit lives on forever.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html