lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue,  6 Oct 2015 09:51:53 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	netdev@...r.kernel.org
Cc:	davem@...emloft.net, sfeldma@...il.com, idosch@...lanox.com,
	eladr@...lanox.com, tgraf@...g.ch, ast@...mgrid.com,
	David.Laight@...LAB.COM, john.fastabend@...il.com
Subject: [patch net-next v3 14/14] rocker: return -EOPNOTSUPP for undefined world ops

Suggested-by: Scott Feldman <sfeldma@...il.com>
Signed-off-by: Jiri Pirko <jiri@...nulli.us>
---
 drivers/net/ethernet/rocker/rocker_main.c | 32 +++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/drivers/net/ethernet/rocker/rocker_main.c b/drivers/net/ethernet/rocker/rocker_main.c
index a2fd7a6..451964b 100644
--- a/drivers/net/ethernet/rocker/rocker_main.c
+++ b/drivers/net/ethernet/rocker/rocker_main.c
@@ -1649,7 +1649,7 @@ static int rocker_world_port_attr_stp_state_set(struct rocker_port *rocker_port,
 	struct rocker_world *world = rocker_port->world;
 
 	if (!world->ops->port_attr_stp_state_set)
-		return 0;
+		return -EOPNOTSUPP;
 	return world->ops->port_attr_stp_state_set(rocker_port->world_port_priv,
 						   state, trans);
 }
@@ -1662,7 +1662,7 @@ rocker_world_port_attr_bridge_flags_set(struct rocker_port *rocker_port,
 	struct rocker_world *world = rocker_port->world;
 
 	if (!world->ops->port_attr_bridge_flags_set)
-		return 0;
+		return -EOPNOTSUPP;
 	return world->ops->port_attr_bridge_flags_set(rocker_port->world_port_priv,
 						      brport_flags, trans);
 }
@@ -1674,7 +1674,7 @@ rocker_world_port_attr_bridge_flags_get(const struct rocker_port *rocker_port,
 	struct rocker_world *world = rocker_port->world;
 
 	if (!world->ops->port_attr_bridge_flags_get)
-		return 0;
+		return -EOPNOTSUPP;
 	return world->ops->port_attr_bridge_flags_get(rocker_port->world_port_priv,
 						      p_brport_flags);
 }
@@ -1687,7 +1687,7 @@ rocker_world_port_obj_vlan_add(struct rocker_port *rocker_port,
 	struct rocker_world *world = rocker_port->world;
 
 	if (!world->ops->port_obj_vlan_add)
-		return 0;
+		return -EOPNOTSUPP;
 	return world->ops->port_obj_vlan_add(rocker_port->world_port_priv,
 					     vlan, trans);
 }
@@ -1699,7 +1699,7 @@ rocker_world_port_obj_vlan_del(struct rocker_port *rocker_port,
 	struct rocker_world *world = rocker_port->world;
 
 	if (!world->ops->port_obj_vlan_del)
-		return 0;
+		return -EOPNOTSUPP;
 	return world->ops->port_obj_vlan_del(rocker_port->world_port_priv,
 					     vlan);
 }
@@ -1712,7 +1712,7 @@ rocker_world_port_obj_vlan_dump(const struct rocker_port *rocker_port,
 	struct rocker_world *world = rocker_port->world;
 
 	if (!world->ops->port_obj_vlan_dump)
-		return 0;
+		return -EOPNOTSUPP;
 	return world->ops->port_obj_vlan_dump(rocker_port->world_port_priv,
 					      vlan, cb);
 }
@@ -1725,7 +1725,7 @@ rocker_world_port_obj_fib4_add(struct rocker_port *rocker_port,
 	struct rocker_world *world = rocker_port->world;
 
 	if (!world->ops->port_obj_fib4_add)
-		return 0;
+		return -EOPNOTSUPP;
 	return world->ops->port_obj_fib4_add(rocker_port->world_port_priv,
 					     fib4, trans);
 }
@@ -1737,7 +1737,7 @@ rocker_world_port_obj_fib4_del(struct rocker_port *rocker_port,
 	struct rocker_world *world = rocker_port->world;
 
 	if (!world->ops->port_obj_fib4_del)
-		return 0;
+		return -EOPNOTSUPP;
 	return world->ops->port_obj_fib4_del(rocker_port->world_port_priv,
 					     fib4);
 }
@@ -1750,7 +1750,7 @@ rocker_world_port_obj_fdb_add(struct rocker_port *rocker_port,
 	struct rocker_world *world = rocker_port->world;
 
 	if (!world->ops->port_obj_fdb_add)
-		return 0;
+		return -EOPNOTSUPP;
 	return world->ops->port_obj_fdb_add(rocker_port->world_port_priv,
 					    fdb, trans);
 }
@@ -1762,7 +1762,7 @@ rocker_world_port_obj_fdb_del(struct rocker_port *rocker_port,
 	struct rocker_world *world = rocker_port->world;
 
 	if (!world->ops->port_obj_fdb_del)
-		return 0;
+		return -EOPNOTSUPP;
 	return world->ops->port_obj_fdb_del(rocker_port->world_port_priv,
 					    fdb);
 }
@@ -1775,7 +1775,7 @@ rocker_world_port_obj_fdb_dump(const struct rocker_port *rocker_port,
 	struct rocker_world *world = rocker_port->world;
 
 	if (!world->ops->port_obj_fdb_dump)
-		return 0;
+		return -EOPNOTSUPP;
 	return world->ops->port_obj_fdb_dump(rocker_port->world_port_priv,
 					     fdb, cb);
 }
@@ -1786,7 +1786,7 @@ static int rocker_world_port_master_linked(struct rocker_port *rocker_port,
 	struct rocker_world *world = rocker_port->world;
 
 	if (!world->ops->port_master_linked)
-		return 0;
+		return -EOPNOTSUPP;
 	return world->ops->port_master_linked(rocker_port->world_port_priv,
 					      master);
 }
@@ -1797,7 +1797,7 @@ static int rocker_world_port_master_unlinked(struct rocker_port *rocker_port,
 	struct rocker_world *world = rocker_port->world;
 
 	if (!world->ops->port_master_unlinked)
-		return 0;
+		return -EOPNOTSUPP;
 	return world->ops->port_master_unlinked(rocker_port->world_port_priv,
 						master);
 }
@@ -1808,7 +1808,7 @@ static int rocker_world_port_neigh_update(struct rocker_port *rocker_port,
 	struct rocker_world *world = rocker_port->world;
 
 	if (!world->ops->port_neigh_update)
-		return 0;
+		return -EOPNOTSUPP;
 	return world->ops->port_neigh_update(rocker_port->world_port_priv, n);
 }
 
@@ -1818,7 +1818,7 @@ static int rocker_world_port_neigh_destroy(struct rocker_port *rocker_port,
 	struct rocker_world *world = rocker_port->world;
 
 	if (!world->ops->port_neigh_destroy)
-		return 0;
+		return -EOPNOTSUPP;
 	return world->ops->port_neigh_destroy(rocker_port->world_port_priv, n);
 }
 
@@ -1829,7 +1829,7 @@ static int rocker_world_port_ev_mac_vlan_seen(struct rocker_port *rocker_port,
 	struct rocker_world *world = rocker_port->world;
 
 	if (!world->ops->port_ev_mac_vlan_seen)
-		return 0;
+		return -EOPNOTSUPP;
 	return world->ops->port_ev_mac_vlan_seen(rocker_port->world_port_priv,
 						 addr, vlan_id);
 }
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ