lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 7 Oct 2015 16:48:59 +0200
From:	Nicolas Dichtel <>
To:	"Eric W. Biederman" <>,
	David Miller <>
Cc:,,, Eric Dumazet <>
Subject: Re: [PATCH net-next 06/15] ipv4: Merge ip_local_out and

Le 06/10/2015 20:53, Eric W. Biederman a écrit :
> It is confusing and silly hiding a paramater so modify all of
> the callers to pass in the appropriate socket or skb->sk if
> no socket is known.
> Signed-off-by: "Eric W. Biederman" <>
> ---
> @@ -456,7 +456,7 @@ packet_routed:
>   	skb->priority = sk->sk_priority;
>   	skb->mark = sk->sk_mark;
> -	res = ip_local_out(skb);
> +	res = ip_local_out(sk, skb);
As stated in the comment at the top of this function (ip_queue_xmit()), skb->sk
can be different from sk. See also commit b0270e91014d ("ipv4: add a sock
pointer to ip_queue_xmit()").
Not sure if this change is right.
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists