lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 7 Oct 2015 09:20:48 -0700
From:	David Daney <ddaney@...iumnetworks.com>
To:	Jean Delvare <jdelvare@...e.de>
CC:	<netdev@...r.kernel.org>, Florian Fainelli <f.fainelli@...il.com>,
	Sunil Goutham <sgoutham@...ium.com>,
	Radha Mohan Chintakuntla <rchintakuntla@...ium.com>,
	David Daney <david.daney@...ium.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] net: mdio-octeon: Drop obsolete Kconfig advice

On 10/07/2015 01:26 AM, Jean Delvare wrote:
> "Y" was the right answer for MDIO_OCTEON when this option was only
> available on CAVIUM_OCTEON_SOC. But now that the option is visible on
> all (64-bit) systems, this piece of advice no longer makes sense. This
> helper module is selected automatically by drivers which need it
> anyway.
>
> Signed-off-by: Jean Delvare <jdelvare@...e.de>
> Fixes: a6d6786452 ("net: mdio-octeon: Modify driver to work on both ThunderX and Octeon")
> Cc: Florian Fainelli <f.fainelli@...il.com>
> Cc: Sunil Goutham <sgoutham@...ium.com>
> Cc: Radha Mohan Chintakuntla <rchintakuntla@...ium.com>
> Cc: David Daney <david.daney@...ium.com>
> Cc: David S. Miller <davem@...emloft.net>

Jean, good catch:
Acked-by: David Daney <david.daney@...ium.com>


> ---
>   drivers/net/phy/Kconfig |    2 --
>   1 file changed, 2 deletions(-)
>
> --- linux-4.3-rc4.orig/drivers/net/phy/Kconfig	2015-09-20 23:32:34.000000000 +0200
> +++ linux-4.3-rc4/drivers/net/phy/Kconfig	2015-10-07 10:18:46.260452322 +0200
> @@ -168,8 +168,6 @@ config MDIO_OCTEON
>   	  busses. It is required by the Octeon and ThunderX ethernet device
>   	  drivers.
>
> -	  If in doubt, say Y.
> -
>   config MDIO_SUN4I
>   	tristate "Allwinner sun4i MDIO interface support"
>   	depends on ARCH_SUNXI
>
>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists