netdev - Re: [patch net-next v2 00/13] rocker: add support for multiple worlds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151007173956.GI2152@nanopsycho.orion>
Date:	Wed, 7 Oct 2015 19:39:56 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	Scott Feldman <sfeldma@...il.com>
Cc:	Netdev <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Ido Schimmel <idosch@...lanox.com>, eladr@...lanox.com,
	Thomas Graf <tgraf@...g.ch>,
	Alexei Starovoitov <ast@...mgrid.com>,
	David Laight <David.Laight@...lab.com>,
	john fastabend <john.fastabend@...il.com>
Subject: Re: [patch net-next v2 00/13] rocker: add support for multiple worlds

Wed, Oct 07, 2015 at 06:53:22PM CEST, sfeldma@...il.com wrote:
>On Tue, Oct 6, 2015 at 11:03 PM, Jiri Pirko <jiri@...nulli.us> wrote:
>> Tue, Oct 06, 2015 at 07:14:39PM CEST, sfeldma@...il.com wrote:
>>>On Tue, Oct 6, 2015 at 12:30 AM, Jiri Pirko <jiri@...nulli.us> wrote:
>>>> Tue, Oct 06, 2015 at 05:56:12AM CEST, sfeldma@...il.com wrote:
>>>>>On Mon, Oct 5, 2015 at 10:43 AM, Jiri Pirko <jiri@...nulli.us> wrote:
>>>>>> From: Jiri Pirko <jiri@...lanox.com>
>>>>>>
>>>>>> This patchset allows new rocker worlds to be easily added in future (like eBPF
>>>>>> based one I have been working on). The main part of the patchset is the OF-DPA
>>>>>> carve-out. It resuts in OF-DPA specific file. Clean cut.
>>>>>>
>>>>>> v1->v2:
>>>>>>  - rtnl rocker mode change userspace expose patch was removed
>>>>>>
>>>>>> Jiri Pirko (13):
>>>>>>   rocker: remove unused rocker_port param from alloc funcs and shorten
>>>>>>     their names
>>>>>>   rocker: rename rocker.h to rocker_hw.h
>>>>>>   rocker: rename rocker.c to rocker_main.c
>>>>>>   rocker: push tlv processing into separate files
>>>>>>   rocker: implement set settings mode command
>>>>>>   rocker: introduce worlds infrastructure
>>>>>>   rocker: introduce OF-DPA world skeleton
>>>>>>   rocker: set default world on port probe and clean world on remove
>>>>>>   rocker: pass "learning" value as a parameter to
>>>>>>     rocker_port_set_learning
>>>>>>   rocker: pre-allocate wait structures during cmd ring init
>>>>>>   rocker: remove trans parameter to rocker_cmd_exec function
>>>>>>   rocker: call rocker_cmd_exec function with "nowait" boolean instead of
>>>>>>     flags
>>>>>>   rocker: move OF-DPA stuff into separate file
>>>>>
>>>>>A couple of my tests are failing with this patchset.  A simple port
>>>>>test is failing and IPv4 routing test is failing.
>>>>>
>>>>>The port test is simple: just connect a port on DUT to a port on
>>>>>another system and assign an IP address to each port and verify IP
>>>>>connectivity.  I have this:
>>>>>
>>>>>   DUT:sw1p1 (11.0.0.1/24) <-----------> host1:eth0 (11.0.0.2/24)
>>>>>
>>>>>The IPv4 routing tests is a bit more complicated to setup.  I'm using
>>>>>OSPF, but I'm not seeing full routes formed in the topology, so I
>>>>>suspect OSPF hellos aren't getting thru.
>>>>>
>>>>>Please fix find/fix these issues and send v3.  I don't want any git
>>>>>bisect issues when running tests.  Thanks.
>>>>
>>>> I fixed that. Sending v3 in a sec. Thanks.
>>>
>>>Sorry, both tests are still broken.  Would you send me your tests
>>>scripts so I can see why your tests are passing?
>>
>> I'm trying some smoke tests including bridge setup and just ip-ip
>> setup by hand. Meybe if you send me your scripts, I can run it locally.
>
>My test scripts are already included in the qemu tree.

Okay, will rework and use your scripts. Hope I will find some time
during this weekend.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html