netdev - Re: [PATCH net-next 3/4] net: Add IPv6 support to VRF device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5615687B.4070405@cumulusnetworks.com>
Date:	Wed, 7 Oct 2015 12:46:19 -0600
From:	David Ahern <dsa@...ulusnetworks.com>
To:	Cong Wang <cwang@...pensource.com>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 3/4] net: Add IPv6 support to VRF device

On 10/7/15 12:42 PM, Cong Wang wrote:
> On Wed, Oct 7, 2015 at 9:50 AM, David Ahern <dsa@...ulusnetworks.com> wrote:
>> Add support for IPv6 to VRF device driver. Implemenation parallels what
>> has been done for IPv4.
> [...]
>> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
>> index b9ebd0d18a52..c878a0bc2137 100644
>> --- a/drivers/net/Kconfig
>> +++ b/drivers/net/Kconfig
>> @@ -300,6 +300,7 @@ config NET_VRF
>>          tristate "Virtual Routing and Forwarding (Lite)"
>>          depends on IP_MULTIPLE_TABLES && IPV6_MULTIPLE_TABLES
>>          depends on NET_L3_MASTER_DEV
>> +       depends on IPV6
>
> So vrf will stop functioning without IPV6? This doesn't look correct...
>

The new functionality does. The inter-module/builtin dependencies are a 
nightmare. I either make VRF device require IPV6 like the IPVLAN driver 
does or I split the module into 2 -- 1 for IPv4 and 1 for IPv6.

David
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html