netdev - [PATCH-next v2 0/4] make non-modular code explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1444253266-22012-1-git-send-email-paul.gortmaker@windriver.com>
Date:	Wed, 7 Oct 2015 17:27:42 -0400
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	<netdev@...r.kernel.org>
CC:	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Alexei Starovoitov <ast@...mgrid.com>,
	Anish Bhatt <anish@...lsio.com>,
	Craig Gallek <kraig@...gle.com>,
	Daniel Borkmann <daniel@...earbox.net>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jamal Hadi Salim <jhs@...atatu.com>,
	John Fastabend <john.r.fastabend@...el.com>,
	Nicolas Dichtel <nicolas.dichtel@...nd.com>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Shani Michaeli <shanim@...lanox.com>,
	Varka Bhadram <varkabhadram@...il.com>
Subject: [PATCH-next v2 0/4] make non-modular code explicitly non-modular

[v2: drop m68k patches that Geert converted to modules; add one ARM
 driver patch ; update net-next baseline to today; switch to ARM
 for build testing.]

In a previous merge window, we made changes to allow better
delineation between modular and non-modular code in commit
0fd972a7d91d6e15393c449492a04d94c0b89351 ("module: relocate module_init
from init.h to module.h").  This allows us to now ensure module code
looks modular and non-modular code does not accidentally look modular
just to avoid suffering build breakage.

Here we target code that is, by nature of their Makefile and/or
Kconfig settings, only available to be built-in, but implicitly
presenting itself as being possibly modular by way of using modular
headers, macros, and functions.

The goal here is to remove that illusion of modularity from these
files, but in a way that leaves the actual runtime unchanged.
In doing so, we remove code that has never been tested and adds
no value to the tree.  And we continue the process of expecting a
level of consistency between the Kconfig/Makefile of code and the
code in use itself.

Fortuntately the net subsystem has relatively few instances, given
the overall amount of code and drivers it contains.  For comparison
there are over 300 instances tree wide, resulting in a possible net
removal of on the order of 5000 lines of unused code.

Build tested on net-next from today, on ARM, since that is the arch
where the one ethernet driver changed here is available.

Paul.
--

Cc: Alexei Starovoitov <ast@...mgrid.com>
Cc: Anish Bhatt <anish@...lsio.com>
Cc: Craig Gallek <kraig@...gle.com>
Cc: Daniel Borkmann <daniel@...earbox.net>
Cc: "David S. Miller" <davem@...emloft.net>
Cc: Eric Dumazet <edumazet@...gle.com>
Cc: Jamal Hadi Salim <jhs@...atatu.com>
Cc: John Fastabend <john.r.fastabend@...el.com>
Cc: Nicolas Dichtel <nicolas.dichtel@...nd.com>
Cc: Or Gerlitz <ogerlitz@...lanox.com>
Cc: Shani Michaeli <shanim@...lanox.com>
Cc: Varka Bhadram <varkabhadram@...il.com>
Cc: netdev@...r.kernel.org

Paul Gortmaker (4):
  net/core: make sock_diag.c explicitly non-modular
  net/dcb: make dcbnl.c explicitly non-modular
  net/sched: make sch_blackhole.c explicitly non-modular
  drivers/net/ethernet: make ti/cpsw-phy-sel.c explicitly non-modular

 drivers/net/ethernet/ti/cpsw-phy-sel.c | 10 ++++------
 net/core/sock_diag.c                   | 14 +++-----------
 net/dcb/dcbnl.c                        | 30 +++---------------------------
 net/sched/sch_blackhole.c              | 15 +++------------
 4 files changed, 13 insertions(+), 56 deletions(-)

-- 
2.6.0.rc3

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html