netdev - Re: [PATCH net] openvswitch: Fix egress tunnel info.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151007093401.GA28717@pox.localdomain>
Date:	Wed, 7 Oct 2015 11:34:01 +0200
From:	Thomas Graf <tgraf@...g.ch>
To:	Jiri Benc <jbenc@...hat.com>
Cc:	Pravin Shelar <pshelar@...ira.com>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net] openvswitch: Fix egress tunnel info.

On 10/07/15 at 10:09am, Jiri Benc wrote:
> The big difference to the other features is this cannot be detected
> until half way through the setup.
> 
> What I'm proposing instead is to introduce a way to clearly and
> unambiguously detect whether lwtunnels are supported or not. We'll need
> this anyway: kernel 4.3 won't really support IPv6 tunneling with ovs,
> yet there's currently no way to determine whether it's supported or not
> (and, unlike with lwtunnel detection, there's not even a hacky way).
> Querying the datapath for the supported features is needed
> nevertheless; it's only logical to use it for the lwtunnel vs. old
> vport decision, too.
> 
> I don't understand why you're opposed to this: it's much cleaner and
> there's no problem with lwtunnels not being used with the 4.3 kernel,
> everything should work just fine.

Extending ovs_dp_cmd_fill_info() to dump a new dp->kernel_features
via a new Netlink attribtue which signals these capabilities looks
like a straight forward way to solve this.

OVS just needs to set NLM_F_ECHO when creating the initial datapath.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html