netdev - Re: [PATCH net-next v2] bridge: allow adding of fdb entries pointing to the bridge device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56150495.2070909@cumulusnetworks.com>
Date:	Wed, 7 Oct 2015 13:40:05 +0200
From:	Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:	Roopa Prabhu <roopa@...ulusnetworks.com>, davem@...emloft.net,
	netdev@...r.kernel.org
Cc:	stephen@...workplumber.org, bridge@...ts.linux-foundation.org
Subject: Re: [PATCH net-next v2] bridge: allow adding of fdb entries pointing
 to the bridge device

On 10/06/2015 06:06 PM, Roopa Prabhu wrote:
> From: Roopa Prabhu <roopa@...ulusnetworks.com>
> 
> This patch enables adding of fdb entries pointing to the bridge device.
> This can be used to propagate mac address of vlan interfaces
> configured on top of the vlan filtering bridge.
> 
> Before:
> $bridge fdb add 44:38:39:00:27:9f dev bridge
> RTNETLINK answers: Invalid argument
> 
> After:
> $bridge fdb add 44:38:39:00:27:9f dev bridge
> 
> Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com>
> Reviewed-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> ---
>  net/bridge/br_fdb.c | 110 ++++++++++++++++++++++++++++++++++++++++------------
>  1 file changed, 85 insertions(+), 25 deletions(-)
> 

Ugh my bad, Dave please don't apply this version, there're still a few rough
edges we need to take care of. Now that bridge's vlan_group can be used in these
functions the vlans should be checked for context-only, i.e. br_vlan_should_use()
and also when a port vlan is deleted its fdb entries are flushed, but that is not
done for the bridge since it wasn't possible to add them like this. So v3 coming
soon to your neighborhood! :-)

Thanks,
 Nik


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html