lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 7 Oct 2015 15:28:35 +0200
From:	Maurizio Lombardi <>
To:	Arnd Bergmann <>,
	"James E.J. Bottomley" <>,,,
	Joe Carnuccio <>,
	Chad Dupuis <>,
	Yuval Mintz <>,
	"David S. Miller" <>,
Subject: Re: [PATCH] bnx2fc: reduce stack usage in __bnx2fc_enable


On 10/07/2015 03:11 PM, Arnd Bergmann wrote:
> -	memset(&npiv_tbl, 0, sizeof(npiv_tbl));
> -	if (hba->cnic->get_fc_npiv_tbl(hba->cnic, &npiv_tbl))
> +	npiv_tbl = kzalloc(sizeof(struct cnic_fc_npiv_tbl), GFP_KERNEL);
> +	if (!npiv_tbl)
>  		goto done;

If kzalloc() fails perhaps the function should return -ENOMEM, not zero.

Maurizio Lombardi
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists