netdev - Re: [net-next] cxgb4: Enhance driver to update FW, when FW is too old

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151008033220.GA15259@hariprasad-pc.asicdesigners.com>
Date:	Thu, 8 Oct 2015 09:02:25 +0530
From:	Hariprasad S <hariprasad@...lsio.com>
To:	Neil Horman <nhorman@...driver.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net, leedom@...lsio.com,
	nirranjan@...lsio.com
Subject: Re: [net-next] cxgb4: Enhance driver to update FW, when FW is too old

On Wed, Oct 07, 2015 at 15:09:57 -0400, Neil Horman wrote:
> On Wed, Oct 07, 2015 at 09:21:40AM +0530, Hariprasad Shenai wrote:
> > t4_check_fw_version() can return several error codes (-EINVAL, -EBUSY,
> > -EAGAIN). The present code sets the adapter state to UNINIT only if its
> > an EFAULT. In all the error cases set the adapter to uninitialized state.
> > 
> > In t4_check_fw_version() if call to t4_read_flash() fails, repeat the
> > operation a few times before returning failure.
> > 
> > Signed-off-by: Hariprasad Shenai <hariprasad@...lsio.com>
> > ---
> >  drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 2 +-
> >  drivers/net/ethernet/chelsio/cxgb4/t4_hw.c      | 6 +++++-
> >  2 files changed, 6 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
> > index 9f1f5b2..c29227e 100644
> > --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
> > +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
> > +		ret = t4_get_fw_version(adap, &adap->params.fw_vers);
> > +
> Shouldn't you only retry if you get an error that indicates the error is
> transient (i.e. EBUSY or EAGAIN)?
> Neil
> 
Yes you are right. Will send a V2 for the same.

Thanks
Hari

> 
> >  	if (ret)
> >  		return ret;
> >  
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html