netdev - Re: [PATCH net-next v2 1/4] switchdev: add bridge attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151008134648.GB17507@ketchup.mtl.sfl>
Date:	Thu, 8 Oct 2015 09:46:48 -0400
From:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:	Jiri Pirko <jiri@...nulli.us>
Cc:	sfeldma@...il.com, netdev@...r.kernel.org, davem@...emloft.net,
	siva.mannem.lnx@...il.com, pjonnala@...adcom.com,
	stephen@...workplumber.org, roopa@...ulusnetworks.com,
	andrew@...n.ch, f.fainelli@...il.com
Subject: Re: [PATCH net-next v2 1/4] switchdev: add bridge attributes

On Oct. Thursday 08 (41) 10:39 AM, Jiri Pirko wrote:
> Thu, Oct 08, 2015 at 08:04:40AM CEST, sfeldma@...il.com wrote:
> >From: Scott Feldman <sfeldma@...il.com>
> >
> >Setting the stage to push bridge-level attributes down to port driver so
> >hardware can be programmed accordingly.  Bridge-level attribute example is
> >ageing_time.  This is a per-bridge attribute, not a per-bridge-port attr.
> >
> >Signed-off-by: Scott Feldman <sfeldma@...il.com>
> >---
> > include/net/switchdev.h      |    5 +++++
> > include/uapi/linux/if_link.h |    2 +-
> > 2 files changed, 6 insertions(+), 1 deletion(-)
> >
> >diff --git a/include/net/switchdev.h b/include/net/switchdev.h
> >index 89266a3..8d92cd0 100644
> >--- a/include/net/switchdev.h
> >+++ b/include/net/switchdev.h
> >@@ -43,6 +43,7 @@ enum switchdev_attr_id {
> > 	SWITCHDEV_ATTR_ID_PORT_PARENT_ID,
> > 	SWITCHDEV_ATTR_ID_PORT_STP_STATE,
> > 	SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS,
> >+	SWITCHDEV_ATTR_ID_BRIDGE,
> > };
> > 
> > struct switchdev_attr {
> >@@ -52,6 +53,10 @@ struct switchdev_attr {
> > 		struct netdev_phys_item_id ppid;	/* PORT_PARENT_ID */
> > 		u8 stp_state;				/* PORT_STP_STATE */
> > 		unsigned long brport_flags;		/* PORT_BRIDGE_FLAGS */
> >+		struct switchdev_attr_bridge {		/* BRIDGE */
> >+			enum ifla_br attr;
> 
> I don't like pushing down IFLA_BR_* values throught switchdev. I think
> it might better to just intruduce:
> SWITCHDEV_ATTR_ID_BRIDGE_AGEING_TIME
> 
> and "u32 ageing_time" here. Something similar to stp_state. Much easier
> to read and does not give blank cheque for passing any bridge IFLA_BR_*
> down to drivers.
> 
> It also aligns with bridge code nicely, I believe.

I would add that pushing bridge-specific aspects down to the drivers
does not really make sense since such notion does not exist for them. A
Linux-bridge is just an untagged-VLAN for the switch chip point-of-view.

Thanks,
-v
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html