netdev - Re: [PATCH net-next 2/4] net: align sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201510090049.oVNrssLb%fengguang.wu@intel.com>
Date:	Fri, 9 Oct 2015 00:19:41 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Eric Dumazet <edumazet@...gle.com>
Cc:	kbuild-all@...org, "David S . Miller" <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH net-next 2/4] net: align sk_refcnt on 128 bytes boundary

Hi Eric,

[auto build test WARNING on net-next/master -- if it's inappropriate base, please ignore]

reproduce: make htmldocs

All warnings (new ones prefixed by >>):

   include/linux/skbuff.h:833: warning: No description found for parameter 'sk'
>> include/net/sock.h:453: warning: Excess struct/union/enum/typedef member 'sk_flags' description in 'sock'
   include/net/sock.h:453: warning: Excess struct/union/enum/typedef member 'sk_incoming_cpu' description in 'sock'
   net/core/gen_stats.c:155: warning: No description found for parameter 'cpu'
   net/core/gen_estimator.c:212: warning: No description found for parameter 'cpu_bstats'
   net/core/gen_estimator.c:303: warning: No description found for parameter 'cpu_bstats'
   net/core/dev.c:6102: warning: No description found for parameter 'len'
   include/linux/netdevice.h:1291: warning: Enum value 'IFF_XMIT_DST_RELEASE_PERM' not described in enum 'netdev_priv_flags'
   include/linux/netdevice.h:1291: warning: Enum value 'IFF_IPVLAN_MASTER' not described in enum 'netdev_priv_flags'
   include/linux/netdevice.h:1291: warning: Enum value 'IFF_IPVLAN_SLAVE' not described in enum 'netdev_priv_flags'
   include/linux/netdevice.h:1791: warning: No description found for parameter 'ptype_all'
   include/linux/netdevice.h:1791: warning: No description found for parameter 'ptype_specific'

vim +453 include/net/sock.h

^1da177e4 Linus Torvalds     2005-04-16  437  	int			sk_write_pending;
d5f642384 Alexey Dobriyan    2008-11-04  438  #ifdef CONFIG_SECURITY
^1da177e4 Linus Torvalds     2005-04-16  439  	void			*sk_security;
d5f642384 Alexey Dobriyan    2008-11-04  440  #endif
4a19ec580 Laszlo Attila Toth 2008-01-30  441  	__u32			sk_mark;
e181a5430 Mathias Krause     2015-07-19  442  #ifdef CONFIG_CGROUP_NET_CLASSID
f84517253 Herbert Xu         2010-05-24  443  	u32			sk_classid;
e181a5430 Mathias Krause     2015-07-19  444  #endif
e1aab161e Glauber Costa      2011-12-11  445  	struct cg_proto		*sk_cgrp;
^1da177e4 Linus Torvalds     2005-04-16  446  	void			(*sk_state_change)(struct sock *sk);
676d23690 David S. Miller    2014-04-11  447  	void			(*sk_data_ready)(struct sock *sk);
^1da177e4 Linus Torvalds     2005-04-16  448  	void			(*sk_write_space)(struct sock *sk);
^1da177e4 Linus Torvalds     2005-04-16  449  	void			(*sk_error_report)(struct sock *sk);
^1da177e4 Linus Torvalds     2005-04-16  450  	int			(*sk_backlog_rcv)(struct sock *sk,
^1da177e4 Linus Torvalds     2005-04-16  451  						  struct sk_buff *skb);
^1da177e4 Linus Torvalds     2005-04-16  452  	void                    (*sk_destruct)(struct sock *sk);
^1da177e4 Linus Torvalds     2005-04-16 @453  };
^1da177e4 Linus Torvalds     2005-04-16  454  
559835ea7 Pravin B Shelar    2013-09-24  455  #define __sk_user_data(sk) ((*((void __rcu **)&(sk)->sk_user_data)))
559835ea7 Pravin B Shelar    2013-09-24  456  
559835ea7 Pravin B Shelar    2013-09-24  457  #define rcu_dereference_sk_user_data(sk)	rcu_dereference(__sk_user_data((sk)))
559835ea7 Pravin B Shelar    2013-09-24  458  #define rcu_assign_sk_user_data(sk, ptr)	rcu_assign_pointer(__sk_user_data((sk)), ptr)
559835ea7 Pravin B Shelar    2013-09-24  459  
4a17fd522 Pavel Emelyanov    2012-04-19  460  /*
4a17fd522 Pavel Emelyanov    2012-04-19  461   * SK_CAN_REUSE and SK_NO_REUSE on a socket mean that the socket is OK

:::::: The code at line 453 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@...970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@...970.osdl.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (6062 bytes)