netdev - Re: [PATCH v2] netfilter: fix bad checksum on IPv6 when NAT is performed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1444339594.14655.392.camel@sakura.staff.proxad.net>
Date:	Thu, 08 Oct 2015 23:26:34 +0200
From:	Maxime Bizon <mbizon@...ebox.fr>
To:	Tom Herbert <tom@...bertland.com>
Cc:	netdev <netdev@...r.kernel.org>, davem <davem@...emloft.net>,
	kaber <kaber@...sh.net>, pablo@...filter.org,
	netfilter-devel <netfilter-devel@...r.kernel.org>
Subject: Re: [PATCH v2] netfilter: fix bad checksum on IPv6 when NAT is
 performed


On Thu, 2015-10-08 at 14:09 -0700, Tom Herbert wrote:

> I think inet_proto_csum_replace16 should be called here.

inet_proto_csum_replace16() wants a non NULL checksum pointer to update,
and there is no such thing here.

I could pass a dummy value, but inet_proto_csum_replace16() will do
twice more work for nothing

or I could modify inet_proto_csum_replace16() to allow a NULL sum
argument.

-- 
Maxime


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html