netdev - Re: [PATCH v2 net-next 1/4] net: SO_INCOMING

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 9 Oct 2015 06:14:49 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Eric Dumazet <edumazet@...gle.com>
Cc:	kbuild-all@...org, "David S . Miller" <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH v2 net-next 1/4] net: SO_INCOMING_CPU setsockopt() support

Hi Eric,

[auto build test WARNING on net-next/master -- if it's inappropriate base, please ignore]

config: sh-titan_defconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=sh 

All warnings (new ones prefixed by >>):

   net/ipv6/udp.c: In function 'udp6_lib_lookup2':
>> net/ipv6/udp.c:276:1: warning: label 'exact_match' defined but not used [-Wunused-label]

vim +/exact_match +276 net/ipv6/udp.c

72289b96 Tom Herbert     2013-01-22  260  		} else if (score == badness && reuseport) {
72289b96 Tom Herbert     2013-01-22  261  			matches++;
8fc54f68 Daniel Borkmann 2014-08-23  262  			if (reciprocal_scale(hash, matches) == 0)
72289b96 Tom Herbert     2013-01-22  263  				result = sk;
72289b96 Tom Herbert     2013-01-22  264  			hash = next_pseudo_random32(hash);
fddc17de Eric Dumazet    2009-11-08  265  		}
fddc17de Eric Dumazet    2009-11-08  266  	}
fddc17de Eric Dumazet    2009-11-08  267  	/*
fddc17de Eric Dumazet    2009-11-08  268  	 * if the nulls value we got at the end of this lookup is
fddc17de Eric Dumazet    2009-11-08  269  	 * not the expected one, we must restart lookup.
fddc17de Eric Dumazet    2009-11-08  270  	 * We probably met an item that was moved to another chain.
fddc17de Eric Dumazet    2009-11-08  271  	 */
fddc17de Eric Dumazet    2009-11-08  272  	if (get_nulls_value(node) != slot2)
fddc17de Eric Dumazet    2009-11-08  273  		goto begin;
fddc17de Eric Dumazet    2009-11-08  274  
fddc17de Eric Dumazet    2009-11-08  275  	if (result) {
fddc17de Eric Dumazet    2009-11-08 @276  exact_match:
c31504dc Eric Dumazet    2010-11-15  277  		if (unlikely(!atomic_inc_not_zero_hint(&result->sk_refcnt, 2)))
fddc17de Eric Dumazet    2009-11-08  278  			result = NULL;
fddc17de Eric Dumazet    2009-11-08  279  		else if (unlikely(compute_score2(result, net, saddr, sport,
fddc17de Eric Dumazet    2009-11-08  280  				  daddr, hnum, dif) < badness)) {
fddc17de Eric Dumazet    2009-11-08  281  			sock_put(result);
fddc17de Eric Dumazet    2009-11-08  282  			goto begin;
fddc17de Eric Dumazet    2009-11-08  283  		}
fddc17de Eric Dumazet    2009-11-08  284  	}

:::::: The code at line 276 was first introduced by commit
:::::: fddc17defa22d8caba1cdfb2e22b50bb4b9f35c0 ipv6: udp: optimize unicast RX path

:::::: TO: Eric Dumazet <eric.dumazet@...il.com>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (15307 bytes)