netdev - Re: [PATCH iproute2] bridge: add batch command support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADdy8Hqit2buVfzeweYzW=_QTOqL6kcwQjBRXfdKk9iYO_1xng@mail.gmail.com>
Date:	Thu, 8 Oct 2015 10:18:59 +0200
From:	Christophe Gouault <christophe.gouault@...nd.com>
To:	Roopa Prabhu <roopa@...ulusnetworks.com>
Cc:	Stephen Hemminger <stephen@...workplumber.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	wkok@...ulusnetworks.com
Subject: Re: [PATCH iproute2] bridge: add batch command support

2015-10-08 7:53 GMT+02:00 Roopa Prabhu <roopa@...ulusnetworks.com>:
> From: Wilson Kok <wkok@...ulusnetworks.com>
>
> This patch adds support to batch bridge commands.
> Follows ip batch code.

Hello Roopa,

Thanks for providing the useful batch feature to the bridge command.

The patch looks good, except a detail:

>         fprintf(stderr,
>  "Usage: bridge [ OPTIONS ] OBJECT { COMMAND | help }\n"
> +"      bridge [ -force ] -batch filename\n"

in the usage display, a tab is used to indent the second form of the
bridge command. Spaces should be used instead, to align with the first
form:

   "Usage: bridge [ OPTIONS ] OBJECT { COMMAND | help }\n"
   "       bridge [ -force ] -batch filename\n"
    ^^^^^^^

Except for this detail,

Acked-by: Christophe Gouault <christophe.gouault@...nd.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html