netdev - Re: [PATCH net] fix return of iptunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201510081823.wuQ7DOFZ%fengguang.wu@intel.com>
Date:	Thu, 8 Oct 2015 18:05:03 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Andreas Schultz <aschultz@...p.net>
Cc:	kbuild-all@...org, netdev@...r.kernel.org,
	Pravin B Shelar <pshelar@...ira.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net] fix return of iptunnel_xmit

Hi Andreas,

[auto build test WARNING on net/master -- if it's inappropriate base, please ignore]

config: microblaze-mmu_defconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=microblaze 

All warnings (new ones prefixed by >>):

   net/ipv4/ip_tunnel_core.c: In function 'iptunnel_xmit':
>> net/ipv4/ip_tunnel_core.c:55:6: warning: unused variable 'pkt_len' [-Wunused-variable]
     int pkt_len = skb->len - skb_inner_network_offset(skb);
         ^

vim +/pkt_len +55 net/ipv4/ip_tunnel_core.c

0e6fbc5b Pravin B Shelar 2013-06-17  39  #include <net/protocol.h>
0e6fbc5b Pravin B Shelar 2013-06-17  40  #include <net/ip_tunnels.h>
0e6fbc5b Pravin B Shelar 2013-06-17  41  #include <net/arp.h>
0e6fbc5b Pravin B Shelar 2013-06-17  42  #include <net/checksum.h>
0e6fbc5b Pravin B Shelar 2013-06-17  43  #include <net/dsfield.h>
0e6fbc5b Pravin B Shelar 2013-06-17  44  #include <net/inet_ecn.h>
0e6fbc5b Pravin B Shelar 2013-06-17  45  #include <net/xfrm.h>
0e6fbc5b Pravin B Shelar 2013-06-17  46  #include <net/net_namespace.h>
0e6fbc5b Pravin B Shelar 2013-06-17  47  #include <net/netns/generic.h>
0e6fbc5b Pravin B Shelar 2013-06-17  48  #include <net/rtnetlink.h>
63d008a4 Jiri Benc       2015-09-22  49  #include <net/dst_metadata.h>
0e6fbc5b Pravin B Shelar 2013-06-17  50  
aad88724 Eric Dumazet    2014-04-15  51  int iptunnel_xmit(struct sock *sk, struct rtable *rt, struct sk_buff *skb,
0e6fbc5b Pravin B Shelar 2013-06-17  52  		  __be32 src, __be32 dst, __u8 proto,
963a88b3 Nicolas Dichtel 2013-09-02  53  		  __u8 tos, __u8 ttl, __be16 df, bool xnet)
0e6fbc5b Pravin B Shelar 2013-06-17  54  {
bc22a0e2 Nicolas Dichtel 2015-09-18 @55  	int pkt_len = skb->len - skb_inner_network_offset(skb);
0e6fbc5b Pravin B Shelar 2013-06-17  56  	struct iphdr *iph;
0e6fbc5b Pravin B Shelar 2013-06-17  57  
963a88b3 Nicolas Dichtel 2013-09-02  58  	skb_scrub_packet(skb, xnet);
963a88b3 Nicolas Dichtel 2013-09-02  59  
7539fadc Tom Herbert     2013-12-15  60  	skb_clear_hash(skb);
0e6fbc5b Pravin B Shelar 2013-06-17  61  	skb_dst_set(skb, &rt->dst);
0e6fbc5b Pravin B Shelar 2013-06-17  62  	memset(IPCB(skb), 0, sizeof(*IPCB(skb)));
0e6fbc5b Pravin B Shelar 2013-06-17  63  

:::::: The code at line 55 was first introduced by commit
:::::: bc22a0e2ea03b75b51a1f722f93821744b5b5ff1 iptunnel: make rx/tx bytes counters consistent

:::::: TO: Nicolas Dichtel <nicolas.dichtel@...nd.com>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (11615 bytes)