netdev - Re: [PATCH 2/2] Do not set shared_ports when nreq > MAX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151008.045454.1028964260721714737.davem@davemloft.net>
Date:	Thu, 08 Oct 2015 04:54:54 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	clsoto@...ux.vnet.ibm.com
Cc:	gerlitz.or@...il.com, matanb@...lanox.com, netdev@...r.kernel.org,
	ogerlitz@...lanox.com, brking@...ux.vnet.ibm.com
Subject: Re: [PATCH 2/2] Do not set shared_ports when nreq > MAX_MSIX

From: Carol Soto <clsoto@...ux.vnet.ibm.com>
Date: Tue, 6 Oct 2015 16:46:06 -0500

> 
> 
> On 10/6/2015 4:39 PM, Or Gerlitz wrote:
>> On Wed, Oct 7, 2015 at 12:27 AM,  <clsoto@...ux.vnet.ibm.com> wrote:
>>> From: Carol L Soto <clsoto@...ux.vnet.ibm.com>
>>>
>>> If we get MAX_MSIX interrupts would like to have each receive ring
>>> with his own msix interrupt line.
>> so 9293267a3e2a  was only partially correct? and/or not fully optimal?
>> please elaborate more on that in your change log.
> just not fully optimal, with commit 9293267a3e2a if I have 64 MSIXs
> and 2 ports I can get 8 rings for each port but then the rings will
> share the interrupt lines. For 64 MSIXs we can have each ring with his
> own interrupt line.
> 
>>> Fixes: 9293267a3e2a ('net/mlx4_core: Capping number of requested MSIXs
>>> to MAX_MSIX')
>>> Signed-off-by: Carol L Soto <clsoto@...ux.vnet.ibm.com>
>> Carol, you didn't use net/mlx4: prefix as ask for mlx4 driver patch
>> titles, so please repost, but before that I'd like to see an ack from
>> Matan for this patch as well.
> Sorry completely missed it. When Matan acks will resend it.

Also please fix you subject to have a proper "mlx4: " subsystem prefix.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html