netdev - Re: [PATCH net-next v4 1/2] fix return of iptunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5617BB92.8000500@cogentembedded.com>
Date:	Fri, 9 Oct 2015 16:05:22 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Andreas Schultz <aschultz@...p.net>, netdev@...r.kernel.org
Cc:	Pravin B Shelar <pshelar@...ira.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next v4 1/2] fix return of iptunnel_xmit

Hello.

On 10/9/2015 12:27 PM, Andreas Schultz wrote:

> All users of iptunnel_xmit expect the return value to be the packet
> length on success (>0), negative for a tx error and zero for a tx
> dropped error. In cset 0e6fbc5b6c6218987c93b8c7ca60cf786062899d the

    Didn't checkpatch.pl compalin about improper commit citing?

> negative return case was lost.

> This bug was introduced when the ip_tunnel_core code was refactored.

> Fixes: 0e6fbc5b6c6218987c93b8c7ca60cf786062899d

    See Documentation/SubmittingPatches for the proper format of this tag.

> Signed-off-by: Andreas Schultz <aschultz@...p.net>
> Acked-by: Jiri Benc <jbenc@...hat.com>
> Acked-by: Pravin B Shelar <pshelar@...ira.com>

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html