netdev - Re: [patch net-next] bridge: try switchdev op first in __vlan_vid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151009224405.GA25393@ketchup.mtl.sfl>
Date:	Fri, 9 Oct 2015 18:44:06 -0400
From:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:	Jiri Pirko <jiri@...nulli.us>
Cc:	netdev@...r.kernel.org, davem@...emloft.net, idosch@...lanox.com,
	eladr@...lanox.com, sfeldma@...il.com, f.fainelli@...il.com,
	linux@...ck-us.net, andrew@...n.ch, john.fastabend@...il.com,
	David.Laight@...LAB.COM
Subject: Re: [patch net-next] bridge: try switchdev op first in
 __vlan_vid_add/del

Hi Jiri,

On Oct. Friday 09 (41) 01:54 PM, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...lanox.com>
> 
> Some drivers need to implement both switchdev vlan ops and
> vid_add/kill ndos. For that to work in bridge code, we need to try
> switchdev op first when adding/deleting vlan id.

Just curious, when would a driver need to have both operations?

I kinda have the same question regarding ndo_fdb_{add,del} and the
bridge_{get,set}link equivalent, which is a bit confusing to me.

> 
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> ---
>  net/bridge/br_vlan.c | 58 ++++++++++++++++++++--------------------------------
>  1 file changed, 22 insertions(+), 36 deletions(-)
> 
> diff --git a/net/bridge/br_vlan.c b/net/bridge/br_vlan.c
> index eae07ee..975deb9 100644
> --- a/net/bridge/br_vlan.c
> +++ b/net/bridge/br_vlan.c
> @@ -72,28 +72,20 @@ static void __vlan_add_flags(struct net_bridge_vlan *v, u16 flags)
>  static int __vlan_vid_add(struct net_device *dev, struct net_bridge *br,
>  			  u16 vid, u16 flags)
>  {
> -	const struct net_device_ops *ops = dev->netdev_ops;
> +	struct switchdev_obj_port_vlan v = {
> +		.obj.id = SWITCHDEV_OBJ_ID_PORT_VLAN,
> +		.flags = flags,
> +		.vid_begin = vid,
> +		.vid_end = vid,
> +	};
>  	int err;
>  
> -	/* If driver uses VLAN ndo ops, use 8021q to install vid
> -	 * on device, otherwise try switchdev ops to install vid.
> +	/* Try switchdev op first. In case it is not supported, fallback to
> +	 * 8021q add.
>  	 */
> -
> -	if (ops->ndo_vlan_rx_add_vid) {
> -		err = vlan_vid_add(dev, br->vlan_proto, vid);
> -	} else {
> -		struct switchdev_obj_port_vlan v = {
> -			.obj.id = SWITCHDEV_OBJ_ID_PORT_VLAN,
> -			.flags = flags,
> -			.vid_begin = vid,
> -			.vid_end = vid,
> -		};
> -
> -		err = switchdev_port_obj_add(dev, &v.obj);
> -		if (err == -EOPNOTSUPP)
> -			err = 0;
> -	}
> -
> +	err = switchdev_port_obj_add(dev, &v.obj);
> +	if (err == -EOPNOTSUPP)
> +		return vlan_vid_add(dev, br->vlan_proto, vid);

                err = vlan_vid_add(dev, br->vlan_proto, vid);

Just being picky: the above line would have been preferred to keep a
single return path, but this does not justify a v2 though.

>  	return err;
>  }

Thanks,
-v
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html