netdev - Re: [PATCH net-next v3 0/4] switchdev: push bridge ageing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGVrzcYdnvR334vSnPbM+Jgm93Coekv3xQJ+O37LHtH0touK6w@mail.gmail.com>
Date:	Thu, 8 Oct 2015 19:40:50 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Scott Feldman <sfeldma@...il.com>
Cc:	netdev <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Jiří Pírko <jiri@...nulli.us>,
	Siva Mannem <siva.mannem.lnx@...il.com>,
	Premkumar Jonnala <pjonnala@...adcom.com>,
	Stephen Hemminger <stephen@...workplumber.org>,
	Roopa Prabhu <roopa@...ulusnetworks.com>,
	Andrew Lunn <andrew@...n.ch>,
	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Subject: Re: [PATCH net-next v3 0/4] switchdev: push bridge ageing_time
 attribute down

2015-10-08 19:23 GMT-07:00  <sfeldma@...il.com>:
> From: Scott Feldman <sfeldma@...il.com>
>
> Push bridge-level attributes down to switchdev drivers.  This patchset
> adds the infrastructure and then pushes, as an example, ageing_time attribute
> down from bridge to switchdev (rocker) driver.  Add some range-checking
> for ageing_time.
>
> # ip link set dev br0 type bridge ageing_time 1000
>
> # ip link set dev br0 type bridge ageing_time 999
> RTNETLINK answers: Numerical result out of range
>
> Up until now, switchdev attrs where port-level attrs, so the netdev used in
> switchdev_attr_set() would be a switch port or bond of switch ports.  With
> bridge-level attrs, the netdev passed to switchdev_attr_set() is the bridge
> netdev.  The same recusive algo is used to visit the leaves of the stacked
> drivers to set the attr, it's just in this case we start one layer higher in
> the stack.  One note is not all ports in the bridge may support setting a
> bridge-level attribute, so rather than failing the entire set, we'll skip over
> those ports returning -EOPNOTSUPP.

Other than the small question on patch #3, this looks good to me:

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

>
> v2->v3: Per Jiri review: push only ageing_time attr down at this time, and
> don't pass raw bridge IFLA_BR_* values; rather use new switchdev attr ID for
> ageing_time.
>
> v1->v2: rebase w/ net-next
>
>
> Scott Feldman (4):
>   switchdev: add bridge ageing_time attribute
>   switchdev: skip over ports returning -EOPNOTSUPP when recursing ports
>   bridge: push bridge setting ageing_time down to switchdev
>   rocker: handle setting bridge ageing_time
>
>  drivers/net/ethernet/rocker/rocker.c |   16 ++++++++++++++++
>  include/net/switchdev.h              |    3 +++
>  net/bridge/br_ioctl.c                |    3 +--
>  net/bridge/br_netlink.c              |    6 +++---
>  net/bridge/br_private.h              |    1 +
>  net/bridge/br_stp.c                  |   23 +++++++++++++++++++++++
>  net/bridge/br_sysfs_br.c             |    3 +--
>  net/switchdev/switchdev.c            |    9 ++++++++-
>  8 files changed, 56 insertions(+), 8 deletions(-)
>
> --
> 1.7.10.4
>



-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html