lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 10 Oct 2015 07:49:43 -0700 From: roopa <roopa@...ulusnetworks.com> To: Scott Feldman <sfeldma@...il.com> CC: "David S. Miller" <davem@...emloft.net>, "stephen@...workplumber.org" <stephen@...workplumber.org>, Nikolay Aleksandrov <nikolay@...ulusnetworks.com>, Netdev <netdev@...r.kernel.org> Subject: Re: [PATCH net-next v3] bridge: allow adding of fdb entries pointing to the bridge device On 10/9/15, 9:52 PM, Scott Feldman wrote: <snip> > @@ -640,7 +641,7 @@ static int fdb_fill_info(struct sk_buff *skb, const struct net_bridge *br, > ndm->ndm_flags = fdb->added_by_external_learn ? NTF_EXT_LEARNED : 0; > ndm->ndm_type = 0; > ndm->ndm_ifindex = fdb->dst ? fdb->dst->dev->ifindex : br->dev->ifindex; > - ndm->ndm_state = fdb_to_nud(fdb); > + ndm->ndm_state = fdb_to_nud(br, fdb); > > if (nla_put(skb, NDA_LLADDR, ETH_ALEN, &fdb->addr)) > goto nla_put_failure; > @@ -785,7 +786,7 @@ static int fdb_add_entry(struct net_bridge_port *source, const __u8 *addr, > } > } > > - if (fdb_to_nud(fdb) != state) { > + if (fdb_to_nud(br, fdb) != state) { > > Hi Roopa, > > Are the above changes to fdb_to_nud() related to the patch subject? > I was trying to figure out this part of the patch...seems unrelated. > Is fdb->dst->br now not valid in some cases? yes, because fdb entries pointing to the bridge will have fdb->dst = NULL. The rest of the bridge code already handles fdb->dst = NULL. Only this function needed a change. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists