netdev - Re: [PATCH net-next v3] BNX2: fix a Null Pointer for stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151011.050701.821276159987364704.davem@davemloft.net>
Date:	Sun, 11 Oct 2015 05:07:01 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	wangweidong1@...wei.com
Cc:	sony.chacko@...gic.com, Dept-HSGLinuxNICDev@...gic.com,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	rui.xiang@...wei.com, manish.chopra@...gic.com
Subject: Re: [PATCH net-next v3] BNX2: fix a Null Pointer for stats_blk

From: Weidong Wang <wangweidong1@...wei.com>
Date: Thu, 8 Oct 2015 18:03:47 +0800

> we have two processes to do:
> P1#: ifconfig eth0 down; which will call bnx2_close, then will
> , and set Null to stats_blk
> P2#: ifconfig eth0; which will call bnx2_get_stats64, it will
> use stats_blk.
> In one case:
>     --P1#--                   --P2#--
>                               stats_blk(no null)
>     bnx2_free_mem
>     ->bp->stats_blk = NULL
>                               GET_64BIT_NET_STATS
> 
> then it will cause 'NULL Pointer' Problem.
> it is as well with 'ethtool -S ethx'.
> 
> Allocate the statistics block at probe time so that this problem is
> impossible
> 
> Signed-off-by: Wang Weidong <wangweidong1@...wei.com>

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html