netdev - Re: [PATCH net-next] tcp: fix RFS vs lockless listeners

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151011.053353.955988140004407245.davem@davemloft.net>
Date:	Sun, 11 Oct 2015 05:33:53 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, willemb@...gle.com, tom@...bertland.com
Subject: Re: [PATCH net-next] tcp: fix RFS vs lockless listeners

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 08 Oct 2015 11:16:48 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Before recent TCP listener patches, we were updating listener
> sk->sk_rxhash before the cloning of master socket.
> 
> children sk_rxhash was therefore correct after the normal 3WHS.
> 
> But with lockless listener, we no longer dirty/change listener sk_rxhash
> as it would be racy.
> 
> We need to correctly update the child sk_rxhash, otherwise first data
> packet wont hit correct cpu if RFS is used.
> 
> Fixes: 079096f103fa ("tcp/dccp: install syn_recv requests into ehash table")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Willem de Bruijn <willemb@...gle.com>
> Cc: Tom Herbert <tom@...bertland.com>

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html