netdev - Re: [PATCH net-next] net: Fix vti use case with oif in dst lookups for IPv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <561C00B9.1020301@cumulusnetworks.com>
Date:	Mon, 12 Oct 2015 12:49:29 -0600
From:	David Ahern <dsa@...ulusnetworks.com>
To:	Steffen Klassert <steffen.klassert@...unet.com>
Cc:	Hajime Tazaki <thehajime@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: Fix vti use case with oif in dst lookups
 for IPv6

On 10/9/15 11:27 AM, David Ahern wrote:
> On 10/9/15 1:17 AM, Steffen Klassert wrote:
>>>> diff --git a/net/ipv6/xfrm6_policy.c b/net/ipv6/xfrm6_policy.c
>>>> index 30caa289c5db..5cedfda4b241 100644
>>>> --- a/net/ipv6/xfrm6_policy.c
>>>> +++ b/net/ipv6/xfrm6_policy.c
>>>> @@ -37,6 +37,7 @@ static struct dst_entry *xfrm6_dst_lookup(struct
>>>> net *net, int tos, int oif,
>>>>
>>>>       memset(&fl6, 0, sizeof(fl6));
>>>>       fl6.flowi6_oif = oif;
>>>> +    fl6.flowi6_flags = FLOWI_FLAG_SKIP_NH_OIF;
>>>>       memcpy(&fl6.daddr, daddr, sizeof(fl6.daddr));
>>>>       if (saddr)
>>>>           memcpy(&fl6.saddr, saddr, sizeof(fl6.saddr));
>>>
>>> I found that this fix is still not sufficient with the mip6
>>> (Mobile IPv6) use case.
>>
>> It does not even fix the vti case. The behaviour of the vti devices is
>> the same, with and without the patch.
>>
>
> The attached patch applied to Linus' tree works for me. Currently the
> above change is not in his tree, so I added it to this patch. Once you
> confirm that it works for you I'll create the delta-patch for net and
> send out.

Steffen: Have you had a chance to try the patch? Does it solve the vti6 
problem for you?

David

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html