netdev - Re: [PATCH net] ipv6: Don't call with rt6_uncached_list_flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151013000221.GD88112@canlin-mbp1.DHCP.thefacebook.com>
Date:	Mon, 12 Oct 2015 17:02:21 -0700
From:	Martin KaFai Lau <kafai@...com>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
CC:	David Miller <davem@...emloft.net>,
	Dmitry Vyukov <dvyukov@...gle.com>, <kuznet@....inr.ac.ru>,
	<jmorris@...ei.org>, <yoshfuji@...ux-ipv6.org>,
	Patrick McHardy <kaber@...sh.net>, <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	<syzkaller@...glegroups.com>, Kostya Serebryany <kcc@...gle.com>,
	Alexander Potapenko <glider@...gle.com>,
	Andrey Konovalov <andreyknvl@...gle.com>,
	Sasha Levin <sasha.levin@...cle.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Maciej Żenczykowski <maze@...gle.com>,
	Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH net] ipv6: Don't call with rt6_uncached_list_flush_dev

On Mon, Oct 12, 2015 at 11:02:08AM -0500, Eric W. Biederman wrote:
>
> As originally written rt6_uncached_list_flush_dev makes no sense when
> called with dev == NULL as it attempts to flush all uncached routes
> regardless of network namespace when dev == NULL.  Which is simply
> incorrect behavior.
Thanks for fixing it.

Reviewed-by: Martin KaFai Lau <kafai@...com>

I also tested the following cases with the presence of DST_NOCACHE entries:
1. rmmod e1000.ko while running netperf
2. unshare(CLONE_NEWNET) as reported by Dmitry

Tested-by: Martin KaFai Lau <kafai@...com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html