netdev - Re: [PATCH net-next v2 1/4] bridge: vlan: use proper rcu for the vlgrp member

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151013071902.GB28618@colbert.mtl.com>
Date:	Tue, 13 Oct 2015 10:19:02 +0300
From:	Ido Schimmel <idosch@...lanox.com>
To:	Nikolay Aleksandrov <razor@...ckwall.org>
CC:	<netdev@...r.kernel.org>, <shm@...ulusnetworks.com>,
	<roopa@...ulusnetworks.com>, <stephen@...workplumber.org>,
	<bridge@...ts.linux-foundation.org>, <davem@...emloft.net>,
	"Nikolay Aleksandrov" <nikolay@...ulusnetworks.com>
Subject: Re: [PATCH net-next v2 1/4] bridge: vlan: use proper rcu for the
 vlgrp member

Mon, Oct 12, 2015 at 10:47:02PM IDT, razor@...ckwall.org wrote:
>From: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
>
>The bridge and port's vlgrp member is already used in RCU way, currently
>we rely on the fact that it cannot disappear while the port exists but
>that is error-prone and we might miss places with improper locking
>(either RCU or RTNL must be held to walk the vlan_list). So make it
>official and use RCU for vlgrp to catch offenders. Introduce proper vlgrp
>accessors and use them consistently throughout the code.
>
>Signed-off-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Reviewed-by: Ido Schimmel <idosch@...lanox.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html