netdev - Re: [PATCH net-next 0/4] tcp: better smp listener behavior

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151013100118.GG11304@distanz.ch>
Date:	Tue, 13 Oct 2015 12:01:18 +0200
From:	Tobias Klauser <tklauser@...tanz.ch>
To:	Daniel Borkmann <daniel@...earbox.net>
Cc:	Eric Dumazet <eric.dumazet@...il.com>,
	Tom Herbert <tom@...bertland.com>,
	Eric Dumazet <edumazet@...gle.com>,
	"David S . Miller" <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 0/4] tcp: better smp listener behavior

On 2015-10-13 at 11:28:13 +0200, Daniel Borkmann <daniel@...earbox.net> wrote:
> On 10/13/2015 11:22 AM, Tobias Klauser wrote:
> >On 2015-10-09 at 20:02:47 +0200, Daniel Borkmann <daniel@...earbox.net> wrote:
> >>On 10/09/2015 12:50 PM, Eric Dumazet wrote:
> >>>On Thu, 2015-10-08 at 20:42 -0700, Tom Herbert wrote:
> >>>>On Thu, Oct 8, 2015 at 8:37 AM, Eric Dumazet <edumazet@...gle.com> wrote:
> >>>>>As promised in last patch series, we implement a better SO_REUSEPORT
> >>>>>strategy, based on cpu affinities if selected by the application.
> >>>>>
> >>>>>We also moved sk_refcnt out of the cache line containing the lookup
> >>>>>keys, as it was considerably slowing down smp operations because
> >>>>>of false sharing. This was simpler than converting listen sockets
> >>>>>to conventional RCU (to avoid sk_refcnt dirtying)
> >>>>>
> >>>>>Could process 6.0 Mpps SYN instead of 4.2 Mpps on my test server.
> >>>>>
> >>>>Is this IPv4, IPv6, or some combination of the two ? :-)
> >>>
> >>>IPv4 only (mostly because I was using trafgen and its csumtcp() only
> >>>deals with IPv4 and I am lazy)
> >>
> >>Agreed, will fix that in trafgen. ;) Thanks!
> >
> >Daniel, I'd have som preliminary patches for trafgen ready to introduce
> >the csumudp6 and csumtcp6 trafgen helper functions (UDP/TCP checksum
> >using IPv6 pseudo headers). If you want I can push them after some
> >further testing later today.
> 
> Was off yesterday, so looks like you beat me to it. So, yes, perfect,
> please do! :)

csumudp6 and csumtcp6 for trafgen are now availble in the netsniff-ng
git as of commit 19c15748 ("trafgen: Add checksum helpers for TCP/UDP
over IPv6").
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html