netdev - Re: [PATCH net-next] route: fib_validate_source remove the <= RT_SCOPE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201510140125.S1Zd1vHc%fengguang.wu@intel.com>
Date:	Wed, 14 Oct 2015 01:17:33 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Xin Long <lucien.xin@...il.com>
Cc:	kbuild-all@...org, network dev <netdev@...r.kernel.org>,
	davem@...emloft.net, fw@...len.de
Subject: Re: [PATCH net-next] route: fib_validate_source remove the <=
 RT_SCOPE_HOST test

Hi Xin,

[auto build test WARNING on net-next/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base]

url:    https://github.com/0day-ci/linux/commits/Xin-Long/route-fib_validate_source-remove-the-RT_SCOPE_HOST-test/20151014-004206
config: cris-etrax-100lx_v2_defconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=cris 

All warnings (new ones prefixed by >>):

   net/ipv4/fib_frontend.c: In function '__fib_validate_source':
>> net/ipv4/fib_frontend.c:328:6: warning: unused variable 'ret' [-Wunused-variable]

vim +/ret +328 net/ipv4/fib_frontend.c

a207a4b2 David S. Miller 2012-06-28  312  
a207a4b2 David S. Miller 2012-06-28  313  	return inet_select_addr(dev, ip_hdr(skb)->saddr, scope);
35ebf65e David S. Miller 2012-06-28  314  }
35ebf65e David S. Miller 2012-06-28  315  
^1da177e Linus Torvalds  2005-04-16  316  /* Given (packet source, input interface) and optional (dst, oif, tos):
6a31d2a9 Eric Dumazet    2010-10-04  317   * - (main) check, that source is valid i.e. not broadcast or our local
6a31d2a9 Eric Dumazet    2010-10-04  318   *   address.
6a31d2a9 Eric Dumazet    2010-10-04  319   * - figure out what "logical" interface this packet arrived
6a31d2a9 Eric Dumazet    2010-10-04  320   *   and calculate "specific destination" address.
6a31d2a9 Eric Dumazet    2010-10-04  321   * - check, that packet arrived from expected physical interface.
ebc0ffae Eric Dumazet    2010-10-05  322   * called with rcu_read_lock()
^1da177e Linus Torvalds  2005-04-16  323   */
7a9bc9b8 David S. Miller 2012-06-29  324  static int __fib_validate_source(struct sk_buff *skb, __be32 src, __be32 dst,
7a9bc9b8 David S. Miller 2012-06-29  325  				 u8 tos, int oif, struct net_device *dev,
7a9bc9b8 David S. Miller 2012-06-29  326  				 int rpf, struct in_device *idev, u32 *itag)
^1da177e Linus Torvalds  2005-04-16  327  {
1dced6a8 Sébastien Barré 2014-08-17 @328  	int ret, no_addr;
^1da177e Linus Torvalds  2005-04-16  329  	struct fib_result res;
9e56e380 David S. Miller 2012-06-28  330  	struct flowi4 fl4;
5b707aaa Denis V. Lunev  2008-01-21  331  	struct net *net;
9e56e380 David S. Miller 2012-06-28  332  	bool dev_match;
^1da177e Linus Torvalds  2005-04-16  333  
9ade2286 David S. Miller 2011-03-12  334  	fl4.flowi4_oif = 0;
385add90 David Ahern     2015-09-29  335  	fl4.flowi4_iif = l3mdev_master_ifindex_rcu(dev);
cd2fbe1b David Ahern     2015-08-13  336  	if (!fl4.flowi4_iif)

:::::: The code at line 328 was first introduced by commit
:::::: 1dced6a854827eb5683f3c57ddbb4595daf145e4 ipv4: Restore accept_local behaviour in fib_validate_source()

:::::: TO: Sébastien Barré <sebastien.barre@...ouvain.be>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (7964 bytes)