netdev - Re: [PATCH] i40evf: fix 32 bit build warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 13 Oct 2015 21:48:15 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Jesse Brandeburg <jesse.brandeburg@...el.com>
Cc:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>, netdev@...r.kernel.org,
	intel-wired-lan@...ts.osuosl.org, kbuild-all@...org,
	Andrew Bowers <andrewx.bowers@...el.com>,
	Shannon Nelson <shannon.nelson@...el.com>,
	Carolyn Wyborny <carolyn.wyborny@...el.com>,
	Don Skidmore <donald.c.skidmore@...el.com>,
	Matthew Vick <matthew.vick@...el.com>,
	John Ronciak <john.ronciak@...el.com>,
	Mitch Williams <mitch.a.williams@...el.com>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH] i40evf: fix 32 bit build warnings

On Tuesday 13 October 2015 12:25:10 Jesse Brandeburg wrote:
> On Tue, 13 Oct 2015 13:37:04 +0200
> Arnd Bergmann <arnd@...db.de> wrote:
> 
> > On Monday 12 October 2015 23:18:21 you wrote:
> > > On Wed, 2015-10-07 at 22:13 +0200, Arnd Bergmann wrote:
> > > > Jesse Brandeburg fixed a bug for 32-bit systems in the i40e driver
> > > > in commit 9c70d7cebfec5 ("i40e: fix 32 bit build warnings"), but the
> > > > same code still exists in the i40evf driver and causes compilation
> > > > warnings in ARM and x86 allmodconfig:
> > > > 
> > > > drivers/net/ethernet/intel/i40evf/i40e_common.c:445:68: warning: cast
> > > > from pointer to integer of different size [-Wpointer-to-int-cast]
> > > > drivers/net/ethernet/intel/i40evf/i40e_common.c:446:71: warning: cast
> > > > from pointer to integer of different size [-Wpointer-to-int-cast]
> > > > 
> > > > This applies the same fix by removing the broken code.
> > > > 
> > > > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > > 
> > > Does not apply at all to my next-queue tree (dev-queue branch), my
> > > guess is that this is already fixed in one of the patches already in my
> > > queue.
> > > 
> > 
> > I still get these warnings on your branch:
> 
> Make sure you're pulling from the dev-queue branch, not the master
> branch of Jeff's next-queue repo.

Indeed, I was only looking at the branch that last got pulled into
net-next, assuming that was the one that was where the fixes for 4.3
are in. Sorry about that.

> I've made that mistake many times, and I do see that the code in
> question is not present in:
> https://git.kernel.org/cgit/linux/kernel/git/jkirsher/next-queue.git/tree/drivers/net/ethernet/intel/i40evf/i40e_common.c?h=dev-queue

Ok, I see your commit 7890f6979a8 ("i40evf: fix overlong BIT defines")
there now. Any chance to get that into mainline? The branch appears
to have a mix of new features and bug fixes, so it looks like it's
at least not destined for 4.3.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html