netdev - Re: [PATCH net-next] packet: fix match_fanout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151012.194302.348030712388370670.davem@davemloft.net>
Date:	Mon, 12 Oct 2015 19:43:02 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, eric@...it.org, willemb@...gle.com
Subject: Re: [PATCH net-next] packet: fix match_fanout_group()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 09 Oct 2015 11:29:32 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Recent TCP listener patches exposed a prior af_packet bug :
> match_fanout_group() blindly assumes it is always safe
> to cast sk to a packet socket to compare fanout with af_packet_priv
> 
> But SYNACK packets can be sent while attached to request_sock, which
> are smaller than a "struct sock".
> 
> We can read non existent memory and crash.
> 
> Fixes: c0de08d04215 ("af_packet: don't emit packet on orig fanout group")
> Fixes: ca6fb0651883 ("tcp: attach SYNACK messages to request sockets instead of listener")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html