netdev - RE: [PATCH] qlcnic: constify qlcnic_mbx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Oct 2015 03:40:46 +0000
From:	Sony Chacko <sony.chacko@...gic.com>
To:	Julia Lawall <Julia.Lawall@...6.fr>,
	Dept-GE Linux NIC Dev <Dept-GELinuxNICDev@...gic.com>
CC:	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	netdev <netdev@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] qlcnic: constify qlcnic_mbx_ops structure

> From: linux-kernel-owner@...r.kernel.org [mailto:linux-kernel-
> owner@...r.kernel.org] On Behalf Of Julia Lawall
> Sent: Sunday, October 11, 2015 4:48 AM
> To: Dept-GE Linux NIC Dev <Dept-GELinuxNICDev@...gic.com>
> Cc: kernel-janitors@...r.kernel.org; netdev <netdev@...r.kernel.org>; linux-
> kernel <linux-kernel@...r.kernel.org>
> Subject: [PATCH] qlcnic: constify qlcnic_mbx_ops structure
> 
> The only instance of a qlcnic_mbx_ops structure is never modified.  Thus the
> declaration of the structure and all references to the structure type can be made
> const.
> 
> In the definition of the qlcnic_mailbox structure, the ops field is no longer lined
> up with the other fields.  This was left as is, to avoid a lot of trivial changes on
> the other lines.
> 
> Done with the help of Coccinelle.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
> 
> ---
>  drivers/net/ethernet/qlogic/qlcnic/qlcnic.h         |    2 +-
>  drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c |    4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
> b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
> index 9f0bdd9..37a731b 100644
> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
> @@ -4048,7 +4048,7 @@ static void qlcnic_83xx_mailbox_worker(struct
> work_struct *work)
>  	struct qlcnic_mailbox *mbx = container_of(work, struct qlcnic_mailbox,
>  						  work);
>  	struct qlcnic_adapter *adapter = mbx->adapter;
> -	struct qlcnic_mbx_ops *mbx_ops = mbx->ops;
> +	const struct qlcnic_mbx_ops *mbx_ops = mbx->ops;
>  	struct device *dev = &adapter->pdev->dev;
>  	atomic_t *rsp_status = &mbx->rsp_status;
>  	struct list_head *head = &mbx->cmd_q;
> @@ -4098,7 +4098,7 @@ static void qlcnic_83xx_mailbox_worker(struct
> work_struct *work)
>  	}
>  }
> 
> -static struct qlcnic_mbx_ops qlcnic_83xx_mbx_ops = {
> +static const struct qlcnic_mbx_ops qlcnic_83xx_mbx_ops = {
>  	.enqueue_cmd    = qlcnic_83xx_enqueue_mbx_cmd,
>  	.dequeue_cmd    = qlcnic_83xx_dequeue_mbx_cmd,
>  	.decode_resp    = qlcnic_83xx_decode_mbx_rsp,
> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h
> b/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h
> index d6696cf..46bbea8 100644
> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h
> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h
> @@ -1092,7 +1092,7 @@ struct qlcnic_filter_hash {  struct qlcnic_mailbox {
>  	struct workqueue_struct	*work_q;
>  	struct qlcnic_adapter	*adapter;
> -	struct qlcnic_mbx_ops	*ops;
> +	const struct qlcnic_mbx_ops *ops;
>  	struct work_struct	work;
>  	struct completion	completion;
>  	struct list_head	cmd_q;
> 
Acked-by: Sony Chacko <sony.chacko@...gic.com>

Thanks,
Sony
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html