netdev - Re: [PATCH net-next 1/4] net/mlx5_core: Fix internal error detection conditions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJ3xEMi=WvU7T1Pd61fBC1vqEkGJGPZwomH=GJ4VYOOogLbW-g@mail.gmail.com>
Date:	Wed, 14 Oct 2015 17:47:03 +0300
From:	Or Gerlitz <gerlitz.or@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	Or Gerlitz <ogerlitz@...lanox.com>,
	Linux Netdev List <netdev@...r.kernel.org>,
	Eli Cohen <eli@...lanox.com>, Amir Vadai <amirv@...lanox.com>
Subject: Re: [PATCH net-next 1/4] net/mlx5_core: Fix internal error detection conditions

On Wed, Oct 14, 2015 at 5:46 AM, David Miller <davem@...emloft.net> wrote:
> From: Or Gerlitz <ogerlitz@...lanox.com>
> Date: Tue, 13 Oct 2015 18:44:06 +0300
>
>> +     if (in_fatal(dev) && !health->sick) {
>> +             health->sick = 1;
>> +             print_health_info(dev);
>> +             queue_work(health->wq, &health->work);
>>       }
>>  }
>>
>> diff --git a/include/linux/mlx5/driver.h b/include/linux/mlx5/driver.h
>> index 41a3287..cd469b9 100644
>> --- a/include/linux/mlx5/driver.h
>> +++ b/include/linux/mlx5/driver.h
>> @@ -393,6 +393,7 @@ struct mlx5_core_health {
>>       struct timer_list               timer;
>>       u32                             prev;
>>       int                             miss_counter;
>> +     int                             sick;
>>       struct workqueue_struct        *wq;
>>       struct work_struct              work;
>>  };

> Please use "bool" and true/false for boolean states.

sure, will fix (just sent that..) in V1
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html