netdev - RE: [PATCH net-next 0/4] Rightsize IFLA_AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <E4CD12F19ABA0C4D8729E087A761DC350F7AD3FC@ORSMSX101.amr.corp.intel.com>
Date:	Thu, 15 Oct 2015 01:32:02 +0000
From:	"Arad, Ronen" <ronen.arad@...el.com>
To:	David Miller <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next 0/4] Rightsize IFLA_AF_SPEC size calculation



>-----Original Message-----
>From: David Miller [mailto:davem@...emloft.net]
>Sent: Wednesday, October 14, 2015 6:44 PM
>To: Arad, Ronen
>Cc: netdev@...r.kernel.org
>Subject: Re: [PATCH net-next 0/4] Rightsize IFLA_AF_SPEC size calculation
>
>From: Ronen Arad <ronen.arad@...el.com>
>Date: Tue, 13 Oct 2015 22:58:30 -0700
>
>> if_nlmsg_size() overestimates the minimum allocation size of netlink dump
>> request (when called from rtnl_calcit()) or the size of the message (when
>called
>> from rtnl_getlink()). This is because ext_filter_mask is not supported by
>> rtnl_link_get_af_size() and rtnl_link_get_size().
>>
>> The over-estimation is significant when at least one netdev has many VLANs
>> configured (8 bytes for each configured VLAN).
>>
>> This patch-set "rightsizes" the protocol specific attribute size calculation
>by
>> propagating ext_filter_mask to rtnl_link_get_af_size() and adding optional
>> filtering aware get_af_size_filtered op in struct rtnl_af_ops. Bridge
>module,
>> which already used filtering aware sizing for notification, is enhanced to
>do
>> the same for netlink dump requests.
>
>There are only three implementations of get_link_af_size, so please just
>simply
>change it's signature by adding the ext_filter_mask parameter instead of
>creating
>a completely new operation.
[@Ronen] I've already submitted a V2 that does that in a simplified
single part patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html