netdev - Re: [PATCH net 1/1] via-rhine: fix VLAN receive handling regression.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8737xck30c.fsf@esperi.org.uk>
Date:	Thu, 15 Oct 2015 08:24:51 +0100
From:	Nick Alcock <nix@...eri.org.uk>
To:	Francois Romieu <romieu@...zoreil.com>
Cc:	netdev@...r.kernel.org, David Miller <davem@...emloft.net>,
	Andrej Ota <andrej@....si>
Subject: Re: [PATCH net 1/1] via-rhine: fix VLAN receive handling regression.

On 14 Oct 2015, Francois Romieu told this:

> From: Andrej Ota <andrej@....si>
>
> Because eth_type_trans() consumes ethernet header worth of bytes, a call
> to read TCI from end of packet using rhine_rx_vlan_tag() no longer works
> as it's reading from an invalid offset.
>
> Tested to be working on PCEngines Alix board.

LGTM, though not tested because I don't have any vlans set up on my VIA
Rhine box and I can't reboot it at the moment. :)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html