netdev - Re: [net-next 05/17] i40e: Change some messages from info to debug only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1444902884.2718.41.camel@perches.com>
Date:	Thu, 15 Oct 2015 02:54:44 -0700
From:	Joe Perches <joe@...ches.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	davem@...emloft.net, Neerav Parikh <neerav.parikh@...el.com>,
	netdev@...r.kernel.org, nhorman@...hat.com, sassmann@...hat.com,
	jogreene@...hat.com,
	Catherine Sullivan <catherine.sullivan@...el.com>,
	Shannon Nelson <shannon.nelson@...el.com>
Subject: Re: [net-next 05/17] i40e: Change some messages from info to debug
 only

On Thu, 2015-10-15 at 02:39 -0700, Jeff Kirsher wrote:
> From: Neerav Parikh <neerav.parikh@...el.com>
> 
> There are several error messages that have been printing when there is
> no functional issue. These messages should be available at debug message
> level only.
[]
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
[]
> @@ -6593,9 +6593,9 @@ static void i40e_reset_and_rebuild(struct i40e_pf *pf, bool reinit)
>  	/* make sure our flow control settings are restored */
>  	ret = i40e_set_fc(&pf->hw, &set_fc_aq_fail, true);
>  	if (ret)
> -		dev_info(&pf->pdev->dev, "set fc fail, err %s aq_err %s\n",
> -			 i40e_stat_str(&pf->hw, ret),
> -			 i40e_aq_str(&pf->hw, pf->hw.aq.asq_last_status));
> +		dev_dbg(&pf->pdev->dev, "setting flow control: ret = %s last_status = %s\n",
> +			i40e_stat_str(&pf->hw, ret),
> +			i40e_aq_str(&pf->hw, pf->hw.aq.asq_last_status));
[]
> @@ -10333,10 +10339,9 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>  	/* get the requested speeds from the fw */
>  	err = i40e_aq_get_phy_capabilities(hw, false, false, &abilities, NULL);
>  	if (err)
> -		dev_info(&pf->pdev->dev,
> -			 "get phy capabilities failed, err %s aq_err %s, advertised speed settings may not be correct\n",
> -			 i40e_stat_str(&pf->hw, err),
> -			 i40e_aq_str(&pf->hw, pf->hw.aq.asq_last_status));
> +		dev_dbg(&pf->pdev->dev, "get requested speeds ret =  %s last_status =  %s\n",
> +			i40e_stat_str(&pf->hw, err),
> +			i40e_aq_str(&pf->hw, pf->hw.aq.asq_last_status));
>  	pf->hw.phy.link_info.requested_speeds = abilities.link_speed;
>  
>  	/* get the supported phy types from the fw */


Perhaps these 2 are functional issues and should remain
dev_info or maybe upgraded to notice or err



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html