netdev - Re: [Patch net-next 3/4] sch_htb: update backlog as well

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 16 Oct 2015 08:19:48 -0400
From:	Jamal Hadi Salim <jhs@...atatu.com>
To:	Cong Wang <xiyou.wangcong@...il.com>
Cc:	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	Cong Wang <cwang@...pensource.com>
Subject: Re: [Patch net-next 3/4] sch_htb: update backlog as well

On 10/15/15 00:21, Cong Wang wrote:
> On Wed, Oct 14, 2015 at 5:25 AM, Jamal Hadi Salim <jhs@...atatu.com> wrote:
>> On 10/12/15 14:38, Cong Wang wrote:
>>>
>>> It is odd to see qlen!=0 but backlog==0, for a real example:
>>>
>>
>> Backlog is a transient stat so a lot of times it should be 0. Only when
>> the CPU is sending faster than the link can handle should you see
>> the backlog grow (and eventually drain to 0).
>
> Of course. But in my case, we were sending a burst of traffic while
> with a lower HTB bw limit, so we can consistently see backlog!=0
> for many seconds.
>

Depending on how much bandwidth you are allowing to be shaped,
this observation is expected. HTB (and any non-work
conserving qdisc) would keep packets backlogged for as long as you
you are instructing it to keep them. If you are sending to the link
faster than the shaping rate, qdisc backlog will grow and take a
while to drain.
[I have seen cases where actually the way the parameters are set
is the problem (unfortunately userspace doesnt do a lot of checking
for sanity).]

Like i said earlier, the idea of keeping track of backlog is useful.
I think the commit log threw me off.
"It is odd to see qlen!=0 but backlog==0"
If you change that commit log then:

Acked-by: Jamal Hadi Salim <jhs@...atatu.com>

cheers,
jamal

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html