lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 15 Oct 2015 20:13:23 -0700 From: roopa <roopa@...ulusnetworks.com> To: David Ahern <dsa@...ulusnetworks.com> CC: stephen@...workplumber.org, netdev@...r.kernel.org Subject: Re: [PATCH iproute2] ip route get: change exit to return to support batch commands On 10/15/15, 7:38 PM, David Ahern wrote: > Hi Roopa: > > On 10/15/15 4:23 PM, Roopa Prabhu wrote: >> From: Roopa Prabhu <roopa@...ulusnetworks.com> >> >> replace exit with return -2 on rtnl_talk failure >> >> Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com> >> --- >> ip/iproute.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/ip/iproute.c b/ip/iproute.c >> index da25548..b137f55 100644 >> --- a/ip/iproute.c >> +++ b/ip/iproute.c >> @@ -1643,7 +1643,7 @@ static int iproute_get(int argc, char **argv) >> req.r.rtm_family = AF_INET; >> >> if (rtnl_talk(&rth, &req.n, &req.n, sizeof(req)) < 0) >> - exit(2); >> + return -2; >> >> if (connected && !from_ok) { >> struct rtmsg *r = NLMSG_DATA(&req.n); >> > > Why return -2 vs exit(2)? What does the change mean to a user or the functionality of ip? Stephen has documented this someplace. I have seen it before. I now forget where. Right now i am just following the rest of the code. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists