netdev - Re: [PATCH nf-next 1/6] netfilter-ipv4: Line layout whitespace fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151016172226.GB3346@salvia>
Date:	Fri, 16 Oct 2015 19:22:26 +0200
From:	Pablo Neira Ayuso <pablo@...filter.org>
To:	Ian Morris <ipm@...rality.org.uk>
Cc:	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH nf-next 1/6] netfilter-ipv4: Line layout whitespace fixes

On Wed, Oct 14, 2015 at 11:17:03PM +0100, Ian Morris wrote:
> Cleanses some whitespace issues by removing a leading space before a tab.
> 
> No changes detected by objdiff.
> 
> Signed-off-by: Ian Morris <ipm@...rality.org.uk>
> ---
>  net/ipv4/netfilter/ipt_ECN.c           | 2 +-
>  net/ipv4/netfilter/nf_nat_pptp.c       | 2 +-
>  net/ipv4/netfilter/nf_nat_snmp_basic.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/net/ipv4/netfilter/ipt_ECN.c b/net/ipv4/netfilter/ipt_ECN.c
> index 2707652..6592708 100644
> --- a/net/ipv4/netfilter/ipt_ECN.c
> +++ b/net/ipv4/netfilter/ipt_ECN.c
> @@ -24,7 +24,7 @@ MODULE_AUTHOR("Harald Welte <laforge@...filter.org>");
>  MODULE_DESCRIPTION("Xtables: Explicit Congestion Notification (ECN) flag modification");
>  
>  /* set ECT codepoint from IP header.
> - * 	return false if there was an error. */
> + *	return false if there was an error. */

In netdev coding style we prefer for multiline comments:

/* This is a comment blah blah blah blah blah blah blah blah blah blah blah blah
 * blah blah blah.
 */

For single line:

/* This is a comment blah blah blah */

This case, I suggest we can even get rid of that comment there since
it's obvious what set_ect_ip() is doing by reading the function name
and looking at what it returns.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html