netdev - Re: [RFC PATCH net-next 0/9] netlink: strict attribute checking option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151015.235007.973370825335101214.davem@davemloft.net>
Date:	Thu, 15 Oct 2015 23:50:07 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jbenc@...hat.com
Cc:	netdev@...r.kernel.org, tgraf@...g.ch
Subject: Re: [RFC PATCH net-next 0/9] netlink: strict attribute checking
 option

From: Jiri Benc <jbenc@...hat.com>
Date: Thu, 15 Oct 2015 18:39:05 +0200

> When sending a netlink request (NLM_F_REQUEST), any unknown attributes are
> ignored. This behavior is problematic in some situations. For example if the
> user asks for a particular config, the request finishes successfully, yet
> the configuraton applied does not work because some of the attributes are
> not supported by the kernel (e.g. because it's older than the user space
> tool).

Although we are probably stuck with this, it was probably a bad idea
to have this behavior as the default.

Better would have been to always error on unrecognized attributes, and
in the ACK give some indication of which attribute was problematic.

But anyhow we are stuck with what we have.  However, I will say I am
disappointed that it is so hard to simply detect that lwtunnel support
is present, which as I understand is what this patch set is trying to
accomplish.

And this is quite an intrusive patch series, and therefore not
suitable for -stable backports.  And that's exactly where you actually
are going to need these changes right?  Older kernels that lack
lwtunnel support.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html