netdev - Re: [net-next 01/17] i40e: Lock for VSI's MAC filter list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20151017.060153.830867376192459210.davem@davemloft.net>
Date:	Sat, 17 Oct 2015 06:01:53 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	kiran.patil@...el.com, netdev@...r.kernel.org, nhorman@...hat.com,
	sassmann@...hat.com, jogreene@...hat.com,
	jesse.brandeburg@...el.com
Subject: Re: [net-next 01/17] i40e: Lock for VSI's MAC filter list

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Fri, 16 Oct 2015 22:28:15 -0700

>  
> +	WARN(!spin_is_locked(&vsi->mac_filter_list_lock),
> +	     "Missing mac_filter_list_lock\n");
> +

spin_is_locked() is, generally speaking, completely inappropriate to
use in assertions.

Because, on uniprocessor builds, it always evalutes to zero.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html