netdev - [PATCH net 0/2] net: mv643xx_eth: TSO TX data corruption fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 18 Oct 2015 16:02:42 +0200
From:	Philipp Kirchhofer <philipp@...ilie-kirchhofer.de>
To:	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	netdev@...r.kernel.org
Cc:	Philipp Kirchhofer <philipp@...ilie-kirchhofer.de>
Subject: [PATCH net 0/2] net: mv643xx_eth: TSO TX data corruption fixes

Hello,

as previously discussed [1] the mv643xx_eth driver has some
issues with data corruption when using TCP segmentation offload (TSO).

The following patch set improves this situation by fixing two data
corruption bugs in the TSO TX path.

Before applying the patches repeatedly accessing large files located on
a SMB share on my NSA325 NAS with TSO enabled resulted in different
hash sums, which confirmed that data corruption is happening during
file transfer. After applying the patches the hash sums were the same.

As this is my first patch submission please feel free to point out any
issues with the patch set.

[1] http://thread.gmane.org/gmane.linux.network/336530

Best wishes,
  Philipp

Philipp Kirchhofer (2):
  net: mv643xx_eth: Ensure proper data alignment in TSO TX path
  net: mv643xx_eth: Defer writing the first TX descriptor when using TSO

 drivers/net/ethernet/marvell/mv643xx_eth.c | 48 +++++++++++++++++++++++++-----
 1 file changed, 40 insertions(+), 8 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html