netdev - Re: [PATCH v2 3/3] net: wireless: b43: Statics are init to 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 19 Oct 2015 18:11:57 +0200
From:	Michael Büsch <m@...s.ch>
To:	Paul McQuade <paulmcquad@...il.com>,
	Gábor Stefanik <netrolller.3d@...il.com>
Cc:	kvalo@...eaurora.org, zajec5@...il.com, davem@...emloft.net,
	joe@...ches.com, johannes.berg@...el.com, sd@...asysnail.net,
	mike.looijmans@...ic.nl, khoroshilov@...ras.ru, cengelma@....at,
	linux-wireless@...r.kernel.org, b43-dev@...ts.infradead.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] net: wireless: b43: Statics are init to 0

On Mon, 19 Oct 2015 17:02:23 +0100
Paul McQuade <paulmcquad@...il.com> wrote:

> diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c
> index 058a9f2..086f0ba 100644
> --- a/drivers/net/wireless/b43/phy_lp.c
> +++ b/drivers/net/wireless/b43/phy_lp.c
> @@ -2502,7 +2502,7 @@ static int lpphy_b2063_tune(struct b43_wldev *dev,
>  {
>  	struct ssb_bus *bus = dev->dev->sdev->bus;
>  
> -	static const struct b206x_channel *chandata = NULL;
> +	static const struct b206x_channel *chandata;
>  	u32 crystal_freq = bus->chipco.pmu.crystalfreq * 1000;
>  	u32 freqref, vco_freq, val1, val2, val3, timeout, timeoutref, count;
>  	u16 old_comm15, scale;


Why on earth is this static anyway? That seems really wrong here.
The static should be removed (and the =NULL init be left in place.)


-- 
Michael

Content of type "application/pgp-signature" skipped