netdev - Re: [PATCH] net: hix5hd2_gmac: avoid integer overload warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151018.200145.258165069418211324.davem@davemloft.net>
Date:	Sun, 18 Oct 2015 20:01:45 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	arnd@...db.de
Cc:	huangdaode@...ilicon.com, joe@...ches.com, liguozhu@...ilicon.com,
	Yisen.Zhuang@...wei.com, netdev@...r.kernel.org,
	linuxarm@...wei.com, salil.mehta@...wei.com,
	kenneth-lee-2012@...mail.com, xuwei5@...ilicon.com,
	lisheng011@...wei.com, linux-kernel@...r.kernel.org,
	lipeng321@...wei.com
Subject: Re: [PATCH] net: hix5hd2_gmac: avoid integer overload warning

From: Arnd Bergmann <arnd@...db.de>
Date: Fri, 16 Oct 2015 12:00:51 +0200

> BITS_RX_EN is an 'unsigned long' constant, so the ones complement of that
> has bits set that do not fit into a 32-bit variable on 64-bit architectures,
> which causes a harmless gcc warning:
> 
> drivers/net/ethernet/hisilicon/hix5hd2_gmac.c: In function 'hix5hd2_port_disable':
> drivers/net/ethernet/hisilicon/hix5hd2_gmac.c:374:2: warning: large integer implicitly truncated to unsigned type [-Woverflow]
>   writel_relaxed(~(BITS_RX_EN | BITS_TX_EN), priv->base + PORT_EN);
> 
> This adds a cast to (u32) to tell gcc that the code is indeed fine.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html